Merge pull request #98 from dry-rb/92-deprecate-eql-predicate

Deprecate eql? in favor of is_eql?

lib/dry/logic/predicates.rb

@@ -9,6 +9,8 @@ module Logic
     module Predicates
       # rubocop:disable Metrics/ModuleLength
       module Methods
+        extend Dry::Core::Deprecations[:dry_logic]
+
         def self.uuid_format(version)
           ::Regexp.new(<<~FORMAT.chomp, ::Regexp::IGNORECASE)
             \\A[0-9A-F]{8}-[0-9A-F]{4}-#{version}[0-9A-F]{3}-[89AB][0-9A-F]{3}-[0-9A-F]{12}\\z
@@ -195,18 +197,19 @@ def excludes?(value, input)
           !includes?(value, input)
         end
 
-        def eql?(left, right)
+        def is_eql?(left, right)
           left.eql?(right)
         end
-
-        def is?(left, right)
-          left.equal?(right)
-        end
+        deprecate :eql?, :is_eql?
 
         def not_eql?(left, right)
           !left.eql?(right)
         end
 
+        def is?(left, right)
+          left.equal?(right)
+        end
+
         def true?(value)
           value.equal?(true)
         end

spec/integration/builder/predicate_spec.rb

@@ -888,8 +888,8 @@
   end
 
   describe "compare methods" do
-    describe :eql? do
-      let(:expression) { ->(*) { eql?(10) } }
+    describe :is_eql? do
+      let(:expression) { ->(*) { is_eql?(10) } }
 
       describe "success" do
         it_behaves_like "predicate" do

spec/shared/predicates.rb

@@ -29,7 +29,7 @@
 
   let(:attr?) { Dry::Logic::Predicates[:attr?] }
 
-  let(:eql?) { Dry::Logic::Predicates[:eql?] }
+  let(:is_eql?) { Dry::Logic::Predicates[:is_eql?] }
 
   let(:size?) { Dry::Logic::Predicates[:size?] }
 

spec/unit/operations/check_spec.rb

@@ -6,7 +6,7 @@
   describe "#call" do
     context "with 1-level nesting" do
       subject(:operation) do
-        described_class.new(Dry::Logic::Rule::Predicate.build(eql?).curry(1), id: :compare, keys: [:num])
+        described_class.new(Dry::Logic::Rule::Predicate.build(is_eql?).curry(1), id: :compare, keys: [:num])
       end
 
       it "applies predicate to args extracted from the input" do
@@ -18,7 +18,7 @@
     context "with 2-levels nesting" do
       subject(:operation) do
         described_class.new(
-          Dry::Logic::Rule::Predicate.build(eql?), id: :compare, keys: [[:nums, :left], [:nums, :right]]
+          Dry::Logic::Rule::Predicate.build(is_eql?), id: :compare, keys: [[:nums, :left], [:nums, :right]]
         )
       end
 
@@ -32,7 +32,7 @@
 
         expect(result.to_ast).to eql(
           [:failure, [:compare, [:check, [
-            [[:nums, :left], [:nums, :right]], [:predicate, [:eql?, [[:left, 1], [:right, 2]]]]
+            [[:nums, :left], [:nums, :right]], [:predicate, [:is_eql?, [[:left, 1], [:right, 2]]]]
           ]]]]
         )
       end

spec/unit/predicates/eql_spec.rb → spec/unit/predicates/is_eql_spec.rb

@@ -3,7 +3,7 @@
 require "dry/logic/predicates"
 
 RSpec.describe Dry::Logic::Predicates, "#eql?" do
-  let(:predicate_name) { :eql? }
+  let(:predicate_name) { :is_eql? }
 
   context "when value is equal to the arg" do
     let(:arguments_list) do