Allow pattern matching in ResultMatcher #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A gotcha that has bitten my team several times is that you cannot pattern match against the wrapped value of a result in the ResultMatcher. Since the [basic matcher documentation][1] shows an example where you can pattern match against the patterns that you specify in your case block, this is easy to assume that it's a built-in for the ResultMatcher. Adding pattern matching is a simple change that makes the whole of the ResultMatcher more flexible and more in-line with the examples in the rest of the documentation. [1]: https://dry-rb.org/gems/dry-matcher/
|
Thanks, it's on our list of things to do before retiring dry-transaction (see dry-rb/dry-transaction#127). I'm merging this PR now, I'll do a few more tweaks to make pattern matching even more flexible. |
|
Thanks for the additional context! I hadn't seen that you were planning to deprecate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A gotcha that has bitten my team several times is that you cannot
pattern match against the wrapped value of a result in the
ResultMatcher.
Since the basic matcher documentation shows an example where you
can pattern match against the patterns that you specify in your case
block, this is easy to assume that it's a built-in for the
ResultMatcher.
Adding pattern matching is a simple change that makes the whole of the
ResultMatcher more flexible and more in-line with the examples in the
rest of the documentation.