Merge pull request #672 from alexxty7/670-fix-values-key

Fix Undefined method `key?' for nil:NilClass error.

lib/dry/validation/values.rb

@@ -70,6 +70,10 @@ def key?(key, hash = data)
             return result
           elsif e.is_a?(Symbol) && a.is_a?(Array)
             return false
+          elsif a.nil?
+            return false
+          elsif a.is_a?(String)
+            return false
           else
             return false unless a.is_a?(Array) ? (e >= 0 && e < a.size) : a.key?(e)
           end

spec/unit/values_spec.rb

@@ -8,7 +8,13 @@
   end
 
   let(:data) do
-    {name: "Jane", address: {city: "Paris", geo: {lat: 1, lon: 2}}, phones: [123, 431]}
+    {
+      name: "Jane",
+      address: {city: "Paris", geo: {lat: 1, lon: 2}},
+      phones: [123, 431],
+      billing_address: nil,
+      card: ""
+    }
   end
 
   describe "#[]" do
@@ -84,6 +90,14 @@
     it "returns false when a path to an array is a symbol as its last segment" do
       expect(values.key?([:phones, :foo])).to be(false)
     end
+
+    it "returns false when a nested key is not present and root key is nil" do
+      expect(values.key?([:billing_address, :not_here])).to be(false)
+    end
+
+    it "returns false when a nested key is not present and root key is string" do
+      expect(values.key?([:card, :not_here])).to be(false)
+    end
   end
 
   describe "#dig" do