Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prelapsarian require latency capture #55

Closed
wants to merge 2 commits into from

Conversation

countvajhula
Copy link
Collaborator

@countvajhula countvajhula commented Jul 21, 2022

Summary of Changes

This PR will not be merged. It's just here to measure the require time latency on an older "prelapsarian" state of the code (i.e. right before "the fall" of the require latency 🐶 ), so that we can add an accurate data point in the tracked benchmark data. The data can be found in each run of the benchmarks job for this branch, in the JSON output in the "run benchmark" step.

This branch is based on 3483112, although I'm not sure if the GitHub UI makes that clear anywhere.

FYI @benknoble 🙂

@countvajhula
Copy link
Collaborator Author

The results from five runs are:

{"name":"(require qi)","unit":"ms","value":490.0}
{"name":"(require qi)","unit":"ms","value":410.00000000000006}
{"name":"(require qi)","unit":"ms","value":490.0}
{"name":"(require qi)","unit":"ms","value":459.99999999999994}
{"name":"(require qi)","unit":"ms","value":570.0}

The average is (~> (490 410 490 460 570) (-< + count) / round) = 484ms.
For good measure, by throwing out the two extreme values, it's (~> (490 490 460) (-< + count) / round) = 480ms

@countvajhula
Copy link
Collaborator Author

countvajhula commented Jul 21, 2022

And for completeness the baseline "postlapsarian" value, five runs on the merged commit that removed the requires: 2ebb865

{"name":"(require qi)","unit":"ms","value":220.0}
{"name":"(require qi)","unit":"ms","value":170.00000000000003}
{"name":"(require qi)","unit":"ms","value":220.00000000000003}
{"name":"(require qi)","unit":"ms","value":160.00000000000003}
{"name":"(require qi)","unit":"ms","value":169.99999999999997}

Same calculations:

> (~> (220 170 220 160 170) (-< + count) / round)
188
> (~> (220 170 170) (-< + count) / round)
187

@countvajhula
Copy link
Collaborator Author

Data added: https://countvajhula.github.io/qi/benchmarks/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant