fix Patch file parse error in windows #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix new line for windows
|
Hi @ds300 |
tlusk
approved these changes
Jun 23, 2021
|
Hello @ds300 |
|
Yeah, this makes sense to me |
|
This was just released in v6.5.0! Thanks for your contribution 🙏🏼 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix new line for windows.
fix issue for: #191, #207, #266, #268,
maybe also for: #236, #244, #280
in windows, the line break is "\r\n". (while it is "\n" in Linux/Unix).
so after split by "\n",
then first char of blank line will be "\r" for window.
so "Treat blank lines as context" should include "\r".