Re-write KKT module #101
Merged
Re-write KKT module #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* KKTSystem structs * KKTBackend structs * Functioning code for CHOLMOD, LDLFact and defaults
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 90.38% 90.60% +0.22%
==========================================
Files 36 43 +7
Lines 2558 2587 +29
==========================================
+ Hits 2312 2344 +32
+ Misses 246 243 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
KKTmodule substantially more modular, by introducing explicit KKT backends and KKT systems, as well as creating individual modules for each underlying linear solver.It does not affect performance.
Doing so allows a more systematic and flexible management of KKT solvers, without the need for complicated
Factoryand outer constructors.