Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Convex.jl's tests #107

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ericphanson
Copy link

Convex.jl v0.14.17+ supports both MOI v0.9 and v0.10, so these can be restored. (taken out in #105)

test/runtests.jl Outdated
@@ -12,7 +12,7 @@ const TvTYPES = [Float32, Float64, BigFloat]

# Check That Tulip.version() matches what's in the Project.toml
tlp_ver = Tulip.version()
toml_ver = TOML.parsefile("../Project.toml")["version"]
toml_ver = TOML.parsefile(joinpath(@__DIR__, "Project.toml"))["version"]
Copy link
Author

@ericphanson ericphanson Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an unrelated fix; .. is relative to the working directory, while @__DIR__ is the (absolute path of the) directory of the file itself, so I think this should be more reliable (e.g. it let me do include("test/runtest.jl") without having to switch to the test directory). Let me know if this is undesired and I can undo it.

edit: oops, forgot .., added it in the next commit

@ericphanson
Copy link
Author

btw, locally I get test_attribute_SolverVersion failing (2 tests with that name, possibly a third but there's so many testsets printed it fills my terminal scrollback buffer 😂), but the Convex.jl ones passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant