Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictor-Corrector algorithm #66

Merged
merged 11 commits into from
Nov 24, 2020
Merged

Predictor-Corrector algorithm #66

merged 11 commits into from
Nov 24, 2020

Conversation

mtanneau
Copy link
Member

Working implementation of the predictor-corrector algorithm; not yet as stable as the homogeneous algorithm.

This comes with a revamp of some internal data structures, especially with respect to options management.
The impact on JuMP/MOI users is limited to changes in parameter handling, namely, some of the strings have been changed.

@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #66 (59b039b) into master (db1db89) will decrease coverage by 0.02%.
The diff coverage is 89.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   89.61%   89.59%   -0.03%     
==========================================
  Files          32       36       +4     
  Lines        2195     2421     +226     
==========================================
+ Hits         1967     2169     +202     
- Misses        228      252      +24     
Impacted Files Coverage Δ
src/KKT/cholmod.jl 96.82% <ø> (ø)
src/KKT/krylov.jl 90.32% <ø> (ø)
src/KKT/lapack.jl 96.00% <ø> (ø)
src/KKT/ldlfact.jl 94.11% <ø> (ø)
src/LinearAlgebra/LinearAlgebra.jl 16.66% <ø> (-11.91%) ⬇️
src/Tulip.jl 100.00% <ø> (ø)
src/utils.jl 85.71% <ø> (-14.29%) ⬇️
src/Interfaces/MOI/attributes.jl 69.81% <50.00%> (ø)
src/Interfaces/tulip_julia_api.jl 69.23% <66.66%> (+4.31%) ⬆️
src/IPM/MPC/MPC.jl 87.58% <87.58%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1db89...59b039b. Read the comment docs.

@mtanneau mtanneau marked this pull request as ready for review November 24, 2020 22:22
@mtanneau mtanneau merged commit f18fe38 into ds4dm:master Nov 24, 2020
@mtanneau mtanneau deleted the MPC branch November 24, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants