Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out explicit zeros in new rows/columns #79

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

mtanneau
Copy link
Member

@mtanneau mtanneau commented Jan 7, 2021

Adds checks on new rows/columns, namely:

  • zero coefficients are filtered out
  • an error is thrown if a coefficient is not finite

It also fixes a bug in add_variable! that had somehow gone undetected.
Thanks @salomonl for bringing this to light!

Closes #77
cc @amontoison

@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #79 (060f2a2) into master (5066f8b) will decrease coverage by 0.12%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   89.91%   89.78%   -0.13%     
==========================================
  Files          36       36              
  Lines        2528     2408     -120     
==========================================
- Hits         2273     2162     -111     
+ Misses        255      246       -9     
Impacted Files Coverage Δ
src/problemData.jl 92.20% <94.44%> (+6.49%) ⬆️
src/KKT/KKT.jl 77.77% <0.00%> (-2.23%) ⬇️
src/Interfaces/tulip_julia_api.jl 67.74% <0.00%> (-1.96%) ⬇️
src/Interfaces/MOI/attributes.jl 65.45% <0.00%> (-1.79%) ⬇️
src/Interfaces/MOI/variables.jl 87.80% <0.00%> (-1.33%) ⬇️
src/KKT/krylov.jl 89.02% <0.00%> (-1.30%) ⬇️
src/Interfaces/MOI/objective.jl 90.00% <0.00%> (-1.18%) ⬇️
src/Interfaces/MOI/constraints.jl 89.14% <0.00%> (-1.10%) ⬇️
src/Presolve/forcing_row.jl 70.47% <0.00%> (-0.83%) ⬇️
src/Interfaces/MOI/MOI_wrapper.jl 80.35% <0.00%> (-0.68%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5066f8b...060f2a2. Read the comment docs.

@amontoison
Copy link
Contributor

Great, thanks @mtanneau !

@mtanneau mtanneau merged commit 8c2349b into ds4dm:master Jan 8, 2021
@mtanneau mtanneau deleted the mt-ZeroCoefficients branch January 8, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when building problem with zero coefficients
3 participants