Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature khalil struct #157

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Feature khalil struct #157

merged 3 commits into from
Apr 14, 2021

Conversation

AntoinePrv
Copy link
Member

Pull request checklist

  • I have open an issue to discuss the proposed changes. Fix Homgenize observation enums #156
  • I have modified/added tests to cover the new changes/features.
  • I have modified/added the documentation to cover the new changes/features.
  • I have ran the tests, checks, and code formatters.

Proposed implementation

Khalil2016 now returns a Khalil2016Obs struct, with .features the data extracted, and .Features the enumeration containing the column description.

@AntoinePrv AntoinePrv changed the base branch from master to v0.6.x April 14, 2021 20:07
@AntoinePrv AntoinePrv merged commit 9164a51 into v0.6.x Apr 14, 2021
@AntoinePrv AntoinePrv deleted the feature-khalil-struct branch April 14, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Homgenize observation enums
1 participant
@AntoinePrv