Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom labels not saving settings properly #213

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

dsafa
Copy link
Owner

@dsafa dsafa commented Jul 15, 2019

Summary

Text labels were not writing the changes back to application settings.

Checklist

Additional details / comments

OnEndEdit was not being overridden properly to write the values back to the source. Additionally fixed removing labels not publishing an edit start message.

Manual test steps (if applicable)

  1. Edit custom label position.
  2. Press apply.
  3. Reset explorer
  4. Observe that the values have been saved properly.

@dsafa dsafa merged commit 8739306 into master Jul 15, 2019
@dsafa dsafa deleted the fix/custom-label-not-saving branch July 15, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text positioning resets to default on explorer.exe restart, or computer reboot
1 participant