Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better unhandled exception detection #214

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Conversation

dsafa
Copy link
Owner

@dsafa dsafa commented Jul 15, 2019

Summary

Prevent the next startup when there is an unhandled exception. This should help mitigate crash loops that can occur due to toolbars being automatically started by windows.

Checklist

Additional details / comments

This adds an application settings file with a boolean property UnhandledException.
In the AppDomain.UnhandledException event handler, set this property to true. And on every startup, check that property to see if there is an unhandled exception. If the property is true, then clear the value and prevent the startup.

If an exception is thrown at startup, then the toolbar will automatically be deactivated and won't start up automatically by explorer.

Manual test steps (if applicable)

  1. Force a crash that is not at startup.
  2. Verify that audioband does not automatically start when explorer restarts.

@dsafa dsafa merged commit a77d391 into master Jul 15, 2019
@dsafa dsafa deleted the feature/crash-loop-detection branch July 15, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 0.9.0 can mess up Windows 8 explorer (or lower I assume)
1 participant