feat: support Airflow v2 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtrntr
force-pushed
the
chore--upgrade-airflow
branch
7 times, most recently
from
1cff20b to
1c5eb91
Compare
guangie88
reviewed
May 24, 2021
xtrntr
force-pushed
the
chore--upgrade-airflow
branch
17 times, most recently
from
9765c8c to
78eb54b
Compare
xtrntr
force-pushed
the
chore--upgrade-airflow
branch
from
78eb54b to
3f7c83a
Compare
guangie88
reviewed
May 31, 2021
guangie88
reviewed
May 31, 2021
xtrntr
commented
May 31, 2021
xtrntr
commented
May 31, 2021
guangie88
reviewed
May 31, 2021
xtrntr
commented
Jun 1, 2021
guangie88
reviewed
Jun 1, 2021
guangie88
reviewed
Jun 1, 2021
guangie88
reviewed
Jun 4, 2021
CHANGELOG.md
Outdated
| @@ -8,11 +8,17 @@ Update `entrypoint.sh` to support the new version of Airflow. | |||
|
|
|||
| BREAKING CHANGES: | |||
|
|
|||
| `ENABLE_AIRFLOW_RBAC_SETUP_AUTH` takes on a different meaning for Airflow V2, | |||
| as only the RBAC UI is available in V2 while RBAC and non-RBAC UI is available | |||
| in V1. It just means to creating an user for V2 with the given env var values. | |||
There was a problem hiding this comment.
Nit: Weird grammar.
Do you mean: "For V2, set to "true", to automatically create the user?
There was a problem hiding this comment.
Fixed, thanks for the catch.
guangie88
reviewed
Jun 4, 2021
CHANGELOG.md
Outdated
| @@ -12,7 +12,7 @@ Update `entrypoint.sh` to support the new version of Airflow. | |||
|
|
|||
| `ENABLE_AIRFLOW_RBAC_SETUP_AUTH` takes on a different meaning for Airflow V2, | |||
| as only the RBAC UI is available in V2 while RBAC and non-RBAC UI is available | |||
| in V1. It just means to creating an user for V2 with the given env var values. | |||
| in V1. It just means to create an user for V2 with the given env vars. | |||
guangie88
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add builds for Airflow v2.