Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewResourceName: AdcsOcspExtension #70

Closed
mavratar opened this issue Jan 29, 2019 · 4 comments
Closed

NewResourceName: AdcsOcspExtension #70

mavratar opened this issue Jan 29, 2019 · 4 comments
Labels
resource proposal The issue is proposing a new resource in the resource module.

Comments

@mavratar
Copy link
Contributor

Description

My team has been working on adding a new DSC resource module to the ActiveDirectoryCSDsc module. This new resource module allows us to add/remove OCSP URI extensions on a Certificate Authority and to restart the CertSvc service if required.

Proposed properties

[Key, Description("Specifies the resource is a single instance, the value must be 'Yes'."), ValueMap{"Yes"}, Values{"Yes"}] String IsSingleInstance;
[Required, Description("Specifies the address of the Ocsp responder from where revocation of this certificate can be checked.")] String OcspUriPath[];
[Write, Description("Specifies if the Ocsp responder Uri should be present or absent."), ValueMap{"Present", "Absent"}, Values{"Present", "Absent"}] String Ensure;
[Write, Description("Specifies if the service should be restarted.")] Boolean RestartService;

    AdcsOcspExtension AddOcspUriPath
    {
        OcspUriPath      = @(
            'http://primary-ocsp-responder/ocsp'
            'http://secondary-ocsp-responder/ocsp'
            'http://tertiary-ocsp-responder/ocsp'
        )
        Ensure           = 'Present'
        IsSingleInstance = 'Yes'
        Restartservice   = $true
    }

Special considerations or limitations

N/A

@PlagueHO PlagueHO added the resource proposal The issue is proposing a new resource in the resource module. label Feb 2, 2019
@PlagueHO
Copy link
Member

PlagueHO commented Feb 2, 2019

Nice @mavratar - that sounds like it would be a great edition if you're wanting to contribute? I've had the same need myself (and ended up using a script resource).

@PlagueHO
Copy link
Member

PlagueHO commented Feb 2, 2019

Just an FYI, I'm changing the structure of this module shortly (today/tomorrow) to make it use the auto-documentation model (see NetworkingDsc, StorageDsc etc). See #53. So you might want to take that into account when putting a resource together for this module.

@PlagueHO
Copy link
Member

PlagueHO commented Feb 2, 2019

Actually, I see you've already submitted the PR. So ignore my comment above. I'll move this project over after your PR is merged so you don't have to do anything.

PlagueHO added a commit that referenced this issue Feb 8, 2019
NewResourceName: AdcsOcspExtension.  A feature to add/remove OCSP URI extensions - New Resource Issue #70.
@PlagueHO
Copy link
Member

PlagueHO commented Feb 8, 2019

This has been added! Thanks @mavratar

FYI, I'm going to begin work on refactoring this module to be auto-documentation - see #53 . Just be aware that this tweaks the layout of the module just slightly. So if you're adding future stuff, just be aware of the slight changes. It's fairly obvious though and makes keeping the docs up-to-date much easier.

@PlagueHO PlagueHO closed this as completed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resource proposal The issue is proposing a new resource in the resource module.
Projects
None yet
Development

No branches or pull requests

2 participants