Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureDevOpsDsc: Enable integration tests #24

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 26, 2021

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Partly issue #9 (but does not fix)

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jan 26, 2021
@johlju
Copy link
Member Author

johlju commented Jan 26, 2021

@SphenicPaul can you sign off on this so I can merge?

@johlju
Copy link
Member Author

johlju commented Jan 26, 2021

@SphenicPaul this is blocked by issue #25. Do you have time to look at it? No hurry.

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Jan 26, 2021
@johlju
Copy link
Member Author

johlju commented Jan 26, 2021

@SphenicPaul The test passed after kicking off the tests again, so lets review and merge this and we can track the problem in issue #25

@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Jan 26, 2021
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this to get the pipeline working.

@johlju johlju merged commit 48e919e into main Jan 27, 2021
@johlju johlju deleted the f/enable-integration-tests branch January 27, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant