Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduledTask: Add Event ValueQueries support, prevent DaysOfWeek ordering causing drift #431

Merged
merged 18 commits into from
Aug 31, 2024

Conversation

Borgquite
Copy link
Contributor

@Borgquite Borgquite commented Aug 23, 2024

Pull Request (PR) description

Adds support for the Event ValueQueries allowing the event to be parsed for values which are sent to the scheduled task script.

Resolves an issue where DaysOfWeek array ordering can cause configuration drift

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90%. Comparing base (58f77e4) to head (56488b7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #431   +/-   ##
===================================
  Coverage    90%    90%           
===================================
  Files        18     18           
  Lines      1803   1818   +15     
===================================
+ Hits       1633   1648   +15     
  Misses      170    170           
Files with missing lines Coverage Δ
...Resources/DSC_ScheduledTask/DSC_ScheduledTask.psm1 88% <100%> (+<1%) ⬆️

@johlju johlju requested a review from PlagueHO August 28, 2024 16:57
Copy link

@kilasuit kilasuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass look this looks alright to me

@johlju
Copy link
Member

johlju commented Aug 31, 2024

Merging this as per @kilasuit comment.

@johlju johlju merged commit c8977b0 into dsccommunity:main Aug 31, 2024
11 of 12 checks passed
@Borgquite Borgquite deleted the schedtask-valuequeries branch August 31, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants