Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xWebAppPool: Move localization strings to strings.psd1 file #469

Closed
johlju opened this issue Sep 29, 2019 · 2 comments · Fixed by #532
Closed

xWebAppPool: Move localization strings to strings.psd1 file #469

johlju opened this issue Sep 29, 2019 · 2 comments · Fixed by #532
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/ in progress The issue is being actively worked on by someone.

Comments

@johlju
Copy link
Member

johlju commented Sep 29, 2019

We should move the localization strings to a strings.psd1 file. See the localization https://dsccommunity.org/guidelines/localization/
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/ help wanted The issue is up for grabs for anyone in the community. labels Sep 29, 2019
@hacky1997
Copy link
Contributor

Okay!! I want to work on this too!! could you please change the label for me?

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Oct 3, 2019
@johlju
Copy link
Member Author

johlju commented Oct 3, 2019

It is yours. But please prioritize the PR currently being reviewed that needs changes.

@omiossec omiossec mentioned this issue Oct 12, 2019
Merged
8 tasks
johlju pushed a commit that referenced this issue Oct 12, 2019
@omiossec @johlju
xWebAppPool: Moved MSFT_xWebAppPool localization strings (#532)
d717519 
- Changes to xWebAppPool
  - Moved MSFT_xWebAppPool localization strings to strings.psd1 (issue #469).
gstorme pushed a commit to gstorme/xWebAdministration that referenced this issue Feb 14, 2020
@omiossec
xWebAppPool: Moved MSFT_xWebAppPool localization strings (dsccommunit…
28b9357 
…y#532)

- Changes to xWebAppPool
  - Moved MSFT_xWebAppPool localization strings to strings.psd1 (issue dsccommunity#469).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/ in progress The issue is being actively worked on by someone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xWebAppPool: Moved MSFT_xWebAppPool localization strings omiossec/xWebAdministration
2 participants
@johlju @hacky1997