Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xWebConfigProperty: Move localization strings to strings.psd1 file #473

Closed
johlju opened this issue Sep 29, 2019 · 1 comment · Fixed by #517
Closed

xWebConfigProperty: Move localization strings to strings.psd1 file #473

johlju opened this issue Sep 29, 2019 · 1 comment · Fixed by #517
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/

Comments

@johlju
Copy link
Member

johlju commented Sep 29, 2019

We should move the localization strings to a strings.psd1 file. See the localization https://dsccommunity.org/guidelines/localization/
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/ help wanted The issue is up for grabs for anyone in the community. labels Sep 29, 2019
@omiossec
Copy link
Contributor

omiossec commented Oct 4, 2019

#517 Pull Request

@omiossec omiossec mentioned this issue Oct 4, 2019
Merged
9 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Oct 4, 2019
johlju pushed a commit that referenced this issue Oct 6, 2019
@omiossec @johlju
xWebConfigProperty: Move localization strings to strings.psd1 file (#517
1b9fc03 
)

- Changes to xWebConfigProperty
  - Move localization strings to strings.psd1 file (issue #473).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Oct 6, 2019
gstorme pushed a commit to gstorme/xWebAdministration that referenced this issue Feb 14, 2020
@omiossec
xWebConfigProperty: Move localization strings to strings.psd1 file (d…
57c95ec 
…sccommunity#517)

- Changes to xWebConfigProperty
  - Move localization strings to strings.psd1 file (issue dsccommunity#473).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xWebConfigProperty: Move localization strings to strings.psd1 file omiossec/xWebAdministration
2 participants
@johlju @omiossec