Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xWebAdministration_mhendric #2

Merged
merged 1 commit into from
Apr 20, 2015

Conversation

mhendric
Copy link
Contributor

Not sure why an extra line was added to all these files. The only files I actually touched were MSFT_xWebConfigKeyValue.schema.mof, and TechNetDocumentation_xWebAdministration.html. Let me know if this is a problem. Note that I did NOT increment the build number in xWebAdministration.psd1.

@vors
Copy link
Contributor

vors commented Apr 17, 2015

Did you use fixers? Can it be, because of the problem in one of them?

@mhendric
Copy link
Contributor Author

I did use the Unicode and spacer fixers on the whole module. Should I not do that?

Sent from my Windows Phone


From: Sergei Vorobevmailto:notifications@github.com
Sent: ‎4/‎17/‎2015 2:57 PM
To: PowerShell/xWebAdministrationmailto:xWebAdministration@noreply.github.com
Cc: Mike Hendricksonmailto:mhendric@microsoft.com
Subject: Re: [xWebAdministration] xWebAdministration_mhendric (#2)

Did you use fixershttps://github.com/PowerShell/DscResource.Tests/blob/master/MetaFixers.psm1? Can it be, because of the problem in one of them?


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-94084351.

@vors
Copy link
Contributor

vors commented Apr 17, 2015

You should, unfortunately there is a bug in one of the fixers PowerShell/DscResource.Tests#1 I'm working on fixing it.

@vors
Copy link
Contributor

vors commented Apr 18, 2015

I fixed problem with extra new lines produced by fixer. Thank you for point it out!

@mhendric
Copy link
Contributor Author

Do I need to redo this change request using the updated tools so that there aren’t unnecessary files being modified?

From: Sergei Vorobev [mailto:notifications@github.com]
Sent: Friday, April 17, 2015 8:02 PM
To: PowerShell/xWebAdministration
Cc: Mike Hendrickson
Subject: Re: [xWebAdministration] xWebAdministration_mhendric (#2)

I fixed problem with extra new lines produced by fixer. Thank you for point it out!


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-94120653.

@vors
Copy link
Contributor

vors commented Apr 20, 2015

It's fine as is. Thank you!

vors added a commit that referenced this pull request Apr 20, 2015
@vors vors merged commit b245466 into dsccommunity:dev Apr 20, 2015
@mhendric mhendric deleted the xWebAdministration_mhendric branch April 23, 2015 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants