Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xWebVirtualDirectory: Moving strings to localization file #512

Merged
merged 4 commits into from
Oct 6, 2019
Merged

xWebVirtualDirectory: Moving strings to localization file #512

merged 4 commits into from
Oct 6, 2019

Conversation

Outek
Copy link
Contributor

@Outek Outek commented Oct 3, 2019 •
edited by johlju
Loading

Pull Request (PR) description

MSFT_xWebVirtualDirectory: Moving strings to localization file

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@Outek Outek mentioned this pull request Oct 3, 2019
Closed
@johlju johlju added the needs review The pull request needs a code review. label Oct 4, 2019
@johlju
Copy link
Member

johlju commented Oct 5, 2019

Please update this PR similar to #510.

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Oct 5, 2019
@johlju
Copy link
Member

johlju commented Oct 5, 2019

Please update this PR similar to #510.

@codecov-io
Copy link

codecov-io commented Oct 5, 2019 •
edited
Loading

Codecov Report

Merging #512 into dev will not change coverage.
The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #512   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          17       17           
  Lines        2661     2661           
=======================================
  Hits         2432     2432           
  Misses        229      229
Impacted Files Coverage Δ
...WebVirtualDirectory/MSFT_xWebVirtualDirectory.psm1 89.36% <87.5%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4290593...a723a9b. Read the comment docs.

johlju
johlju requested changes Oct 5, 2019
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Outek)

CHANGELOG.md, line 6 at r2 (raw file):

 Moved MSFT_xWebVirtualDirectory localization strings to strings.psd1.

Please move this under a new entry - Changes to xWebVirtualDirectory.

DSCResources/MSFT_xWebVirtualDirectory/MSFT_xWebVirtualDirectory.psm1, line 190 at r2 (raw file):

$LocalizedData

This one was missed.

johlju
johlju requested changes Oct 5, 2019
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Outek)

CHANGELOG.md, line 6 at r2 (raw file):

Moved MSFT_xWebVirtualDirectory localization strings to strings.psd1.

Please also update with the correct issue (see other entries for example)

johlju
johlju approved these changes Oct 6, 2019
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r3, 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Oct 6, 2019
@johlju johlju changed the title MSFT_xWebVirtualDirectory: Moving strings to localization file xWebVirtualDirectory: Moving strings to localization file Oct 6, 2019
@johlju johlju merged commit 8ec70c5 into dsccommunity:dev Oct 6, 2019
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Oct 6, 2019
gstorme pushed a commit to gstorme/xWebAdministration that referenced this pull request Feb 14, 2020
@Outek
xWebVirtualDirectory: Moving strings to localization file (dsccommuni…
74c1339 
…ty#512)

- Changes to xWebVirtualDirectory
  - Moved MSFT_xWebVirtualDirectory localization strings to strings.psd1 (issue dsccommunity#477).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xWebVirtualDirectory: Move localization strings to strings.psd1 file
3 participants
@Outek @johlju @codecov-io