Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xIisModule: Move localization strings to strings.psd1 #521

Merged
merged 6 commits into from
Oct 6, 2019
Merged

xIisModule: Move localization strings to strings.psd1 #521

merged 6 commits into from
Oct 6, 2019

Conversation

Outek
Copy link
Contributor

@Outek Outek commented Oct 5, 2019

Pull Request (PR) description

MSFT_xIisModule: Move localization strings to strings.psd1

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@Outek
Copy link
Contributor Author

Outek commented Oct 5, 2019

#466

@codecov-io
Copy link

codecov-io commented Oct 5, 2019

Codecov Report

Merging #521 into dev will not change coverage.
The diff coverage is 6.25%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #521   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          17       17           
  Lines        2661     2661           
=======================================
  Hits         2432     2432           
  Misses        229      229
Impacted Files Coverage Δ
DSCResources/MSFT_xIisModule/MSFT_xIisModule.psm1 5.66% <6.25%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10338a1...2d87e47. Read the comment docs.

@johlju
Copy link
Member

johlju commented Oct 5, 2019

Please update this PR similar to #510.

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Oct 5, 2019
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Outek)


CHANGELOG.md, line 6 at r2 (raw file):

- Moved xIisModule localization strings to strings.psd1.

We should move this entry under a new - Changes to xIisModule entry Please also update with the correct issue (see other entries for example)

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju changed the title MSFT_xIisModule: Move localization strings to strings.psd1 xIisModule: Move localization strings to strings.psd1 Oct 6, 2019
@johlju johlju merged commit 6ded0de into dsccommunity:dev Oct 6, 2019
@johlju johlju removed the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Oct 6, 2019
gstorme pushed a commit to gstorme/xWebAdministration that referenced this pull request Feb 14, 2020
- Changes to xIisModule entry
  - Moved xIisModule localization strings to strings.psd1 (issue dsccommunity#466).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xIisModule: Move localization strings to strings.psd1 file
3 participants