BREAKING CHANGE: xWebAdministration renamed to WebAdministrationDsc: Renamed all DSCResources, Examples, Modules and Tests where applicable

[nickgw]

Pull Request (PR) description

xWebAdministration renamed to WebAdministrationDsc

This Pull Request (PR) fixes the following issues

• Fixes Rename this resource module to WebAdministrationDsc #213
• Fixes Remove deprecated xWebConfigKeyValue resource in future release #369
• Fixes xIisHandler: Remove deprecated resource #363

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[johlju]

Reviewed 2 of 144 files at r1, 1 of 1 files at r2, 22 of 42 files at r3, 1 of 1 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), 6 unresolved discussions (waiting on @nickgw)

---

tests/TestHelper/CommonTestHelper.psm1 line 238 at r4 (raw file):

#>
function New-SelfSignedCertificateEx {
    [OutputType('[System.Security.Cryptography.X509Certificates.X509Certificate2]')]

We should not need this as we use the command from the module PSPKI. 🤔 See https://github.com/dsccommunity/xWebAdministration/blob/334575ac032f2b04f98bdaed1149f904d5d35899/tests/Unit/xWebAdministration.Common.Tests.ps1#L27

I added it in one of the PR's I pused yesterday.

Code quote:

New-SelfSignedCertificateEx

[johlju]

@nickgw it seems this row fails in the integration tests:

https://github.com/dsccommunity/xWebAdministration/blob/df669ce662ff3e03ad1268498086204f34cb8717/tests/Integration/DSC_WebApplication.Integration.Tests.ps1#L102

I'm think, can it be that we run the integration tests to fast. Can we test adding Start-Sleep -Seconds 5 before running the command? If that doesn't work I suggest comment that test, the create an issue to track it and we move on. Let us in that case fix it in another PR. What do you think?

[johlju]

Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nickgw)

---

README.md line 8 at r5 (raw file):

![Azure DevOps coverage (branch)](https://img.shields.io/azure-devops/coverage/dsccommunity/WebAdministrationDsc/7/main)
[![Azure DevOps tests](https://img.shields.io/azure-devops/tests/dsccommunity/WebAdministrationDsc/7/main)](https://dsccommunity.visualstudio.com/WebAdministrationDsc/_test/analytics?definitionId=7&contextType=build)
[![codecov](https://codecov.io/gh/dsccommunity/xWebAdministration/branch/main/graph/badge.svg)](https://codecov.io/gh/dsccommunity/xWebAdministration)

Should be:

Suggestion:

WebAdministrationDsc

[johlju]

It is like the Get-TargetResource function throws an error or returns some unexpected value that Get-DscConfiguration does not like. 🤔

[johlju]

Reviewable status: 160 of 161 files reviewed, 2 unresolved discussions (waiting on @johlju and @nickgw)

---

tests/Integration/DSC_WebApplication.Integration.Tests.ps1 line 74 at r7 (raw file):

        It 'Should compile without throwing' {
            {
                Invoke-Expression -Command "$($script:dscResourceName)_Present -ConfigurationData `$DSCConfig -OutputPath `$TestDrive"

This should be $configData now?

Code quote:

$DSCConfig

[johlju]

Now it fails with the previous error again. Looking at the tests thay run for xWeb I see the do run in a different order now... It might be something a previous test added that made the test, by luck, work previously. 🤔

[johlju]

I think the integration test need to be refactored, like you tried too. But we can do that in another PR. I happy to comment out the test and make an issue for it to be fixed, by someone, in another PR.

[nickgw]

I think the integration test need to be refactored, like you tried too. But we can do that in another PR. I happy to comment out the test and make an issue for it to be fixed, by someone, in another PR.

Created this for the failing integration test: #606

[johlju]

Reviewed 2 of 2 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nickgw)

[johlju]

Awesome work @nickgw! This PR is ready, I will rename this repo as soon as I have a chance.

[johlju]

Reviewed 13 of 13 files at r12, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nickgw)

[johlju]

Waiting for the API key to be update on the pipeline so we can merge this.