Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xPSDesiredStateConfiguration: Adding a Branches section to the README.md #417

Merged
merged 2 commits into from
May 24, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented May 21, 2018

Fixes #416


This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label May 21, 2018
@codecov-io
Copy link

codecov-io commented May 21, 2018

Codecov Report

Merging #417 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #417   +/-   ##
===================================
  Coverage    73%    73%           
===================================
  Files        27     27           
  Lines      3992   3992           
  Branches      4      4           
===================================
  Hits       2954   2954           
  Misses     1034   1034           
  Partials      4      4

@johlju
Copy link
Member Author

johlju commented May 23, 2018

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

- Adding a Branches section to the README.md with Codecov badges for both
  master and dev branch (issue dsccommunity#416).
@johlju
Copy link
Member Author

johlju commented May 24, 2018

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 3221e03 into dsccommunity:dev May 24, 2018
@johlju johlju deleted the fix-badges branch June 4, 2018 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants