Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples to PowerShell Gallery #430

Merged
merged 13 commits into from
Jul 4, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 2, 2018

  • Renamed and updated examples to be able to publish them to PowerShell Gallery.
    • Sample_xWindowsProcess_Start.ps1 → xWindowsProcess_StartProcessConfig.ps1
    • Sample_xWindowsProcess_StartUnderUser.ps1 → xWindowsProcess_StartProcessUnderUserConfig.ps1
    • Sample_xWindowsProcess_Stop.ps1 → xWindowsProcess_StopProcessConfig.ps1
    • Sample_xWindowsProcess_StopUnderUser.ps1 → xWindowsProcess_StopProcessUnderUserConfig.ps1
    • Sample_xUser_CreateUser.ps1.ps1 → xUser_CreateUserConfig.ps1
    • Sample_xUser_Generic.ps1.ps1 → xUser_CreateUserDetailedConfig.ps1
    • Sample_xWindowsFeature.ps1 → xWindowsFeature_AddFeatureConfig.ps1
    • Sample_xWindowsFeatureSet_Install.ps1 → xWindowsFeatureSet_AddFeaturesConfig.ps1
    • Sample_xWindowsFeatureSet_Uninstall.ps1 → xWindowsFeatureSet_RemoveFeaturesConfig.ps1
    • Sample_xRegistryResource_AddKey.ps1 → xRegistryResource_AddKeyConfig.ps1
    • Sample_xRegistryResource_RemoveKey.ps1 → xRegistryResource_RemoveKeyConfig.ps1
    • Sample_xRegistryResource_AddOrModifyValue.ps1 → xRegistryResource_AddOrModifyValueConfig.ps1
    • Sample_xRegistryResource_RemoveValue.ps1 → xRegistryResource_RemoveValueConfig.ps1
    • Sample_xService_CreateService.ps1 → xService_CreateServiceConfig.ps1
    • Sample_xService_DeleteService.ps1 → xService_RemoveServiceConfig.ps1
    • Sample_xServiceSet_StartServices.ps1 → xServiceSet_StartServicesConfig.ps1
    • Sample_xServiceSet_BuiltInAccount → xServiceSet_EnsureBuiltInAccountConfig.ps1
    • Sample_xWindowsPackageCab → xWindowsPackageCab_InstallPackageConfig
    • Sample_xWindowsOptionalFeature.ps1 → xWindowsOptionalFeature_EnableConfig.ps1
    • Sample_xWindowsOptionalFeatureSet_Enable.ps1 → xWindowsOptionalFeatureSet_EnableConfig.ps1
    • Sample_xWindowsOptionalFeatureSet_Disable.ps1 → xWindowsOptionalFeatureSet_DisableConfig.ps1
    • Sample_xRemoteFileUsingProxy.ps1 → xRemoteFile_DownloadFileUsingProxyConfig.ps1
    • Sample_xRemoteFile.ps1 → xRemoteFile_DownloadFileConfig.ps1
    • Sample_xProcessSet_Start.ps1 → xProcessSet_StartProcessConfig.ps1
    • Sample_xProcessSet_Stop.ps1 → xProcessSet_StopProcessConfig.ps1
    • Sample_xMsiPackage_UninstallPackageFromHttps.ps1 → xMsiPackage_UninstallPackageFromHttpsConfig.ps1
    • Sample_xMsiPackage_UninstallPackageFromFile.ps1 → xMsiPackage_UninstallPackageFromFileConfig.ps1
    • Sample_xMsiPackage_InstallPackageFromFile → xMsiPackage_InstallPackageConfig.ps1
    • Sample_xGroup_SetMembers.ps1 → xGroup_SetMembersConfig.ps1
    • Sample_xGroup_RemoveMembers.ps1 → xGroup_RemoveMembersConfig.ps1
    • Sample_xGroupSet_AddMembers.ps1 → xGroupSet_AddMembersConfig.ps1
    • Sample_xFileUpload.ps1 → xFileUpload_UploadToSMBShareConfig.ps1
    • Sample_xEnvironment_CreateMultiplePathVariables.ps1 → xEnvironment_AddMultiplePathsConfig.ps1
    • Sample_xEnvironment_RemovePathVariables.ps1 → xEnvironment_RemoveMultiplePathsConfig.ps1
    • Sample_xEnvironment_CreateNonPathVariable.ps1 → xEnvironment_CreateNonPathVariableConfig.ps1
    • Sample_xEnvironment_Remove.ps1 → xEnvironment_RemoveVariableConfig.ps1
    • Sample_xArchive_ExpandArchiveChecksumAndForce.ps1 → xArchive_ExpandArchiveChecksumAndForceConfig.ps1
    • Sample_xArchive_ExpandArchiveDefaultValidationAndForce.ps1 → xArchive_ExpandArchiveDefaultValidationAndForceConfig.ps1
    • Sample_xArchive_ExpandArchiveNoValidation.ps1 → xArchive_ExpandArchiveNoValidationConfig.ps1
    • Sample_xArchive_ExpandArchiveNoValidationCredential.ps1 → xArchive_ExpandArchiveNoValidationCredentialConfig.ps1
    • Sample_xArchive_RemoveArchiveChecksum.ps1 → xArchive_RemoveArchiveChecksumConfig.ps1
    • Sample_xArchive_RemoveArchiveNoValidation.ps1 → xArchive_RemoveArchiveNoValidationConfig.ps1
    • Sample_InstallExeCreds_xPackage.ps1 → xPackage_InstallExeUsingCredentialsConfig.ps1
    • Sample_InstallExeCredsRegistry_xPackage.ps1 → xPackage_InstallExeUsingCredentialsAndRegistryConfig.ps1
    • Sample_InstallMSI_xPackage.ps1 → xPackage_InstallMsiConfig.ps1
    • Sample_InstallMSIProductId_xPackage.ps1 → xPackage_InstallMsiUsingProductIdConfig.ps1
  • New examples
    • xUser_RemoveUserConfig.ps1
    • xWindowsFeature_AddFeatureUsingCredentialConfig.ps1
    • xWindowsFeature_AddFeatureWithLogPathConfig.ps1
    • xWindowsFeature_RemoveFeatureConfig.ps1
    • xService_ChangeServiceStateConfig.ps1
    • xWindowsOptionalFeature_DisableConfig.ps1
    • xPSEndpoint_NewConfig.ps1
    • xPSEndpoint_NewWithDefaultsConfig.ps1
    • xPSEndpoint_RemoveConfig.ps1
    • xPSEndpoint_NewCustomConfig.ps1
  • Removed examples
    • Sample_xPSSessionConfiguration.ps1 - This file was split up in several examples,
      those starting with 'xPSEndpoint*'.
    • Sample_xMsiPackage_InstallPackageFromHttp - This was added to the example
      xMsiPackage_InstallPackageConfig.ps1 so the example sows either URI scheme.
    • Sample_xEnvironment_CreatePathVariable.ps1 - Same as the new example
      xEnvironment_AddMultiplePaths.ps1

This change is Reviewable

@johlju johlju added the on hold The issue or pull request has been put on hold by a maintainer. label Jul 2, 2018
@codecov-io
Copy link

codecov-io commented Jul 2, 2018

Codecov Report

Merging #430 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #430   +/-   ##
===================================
  Coverage    73%    73%           
===================================
  Files        27     27           
  Lines      3995   3995           
  Branches      4      4           
===================================
  Hits       2921   2921           
  Misses     1070   1070           
  Partials      4      4

@johlju johlju force-pushed the add-more-gallery-examples branch from a67003d to ce15fe5 Compare July 3, 2018 15:36
@johlju johlju added needs review The pull request needs a code review. and removed on hold The issue or pull request has been put on hold by a maintainer. labels Jul 3, 2018
@johlju johlju changed the title WIP: Add more examples to PowerShell Gallery Add more examples to PowerShell Gallery Jul 3, 2018
@johlju
Copy link
Member Author

johlju commented Jul 4, 2018

:LGTM:


Reviewed 106 of 106 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Saw this filename in the README.md that I missed to rename properly when I was about to add the commit message.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 8908dd9 into dsccommunity:dev Jul 4, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Jul 4, 2018
@johlju johlju deleted the add-more-gallery-examples branch July 4, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants