Upload on didPrepare hook to fix gzip issues #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duizendnegen
approved these changes
Jun 17, 2018
There was a problem hiding this comment.
Let's leave a comment in the source code indicating that this is semantically undesirable but works around this specific issue, and link to the issues on Github, both here and on the sentry repo.
Otherwise lgtm, it's a good approach, better than unzipping again imo
simonihmig
force-pushed
the
alternative-hook
branch
from
dde34cb to
c172589
Compare
Hey @duizendnegen, just added that! |
|
Well, we can try ... and wait for bug reports if it breaks anything for anyone. |
|
@dschmidt can we get a release with this, please? 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just another attempt at fixing/working around #26.
My super simple approach here: use another hook (
didPreparehere) that runs beforewillUpload(wheree-c-d-gzipwill gzip the files) to upload the (still) uncompressed files to Sentry.I don't know if I am missing something, but it seems to work for me. And it does not suffer from the problem of #42, which AFAICT does not work with other compression algorithms than plain gzip (e.g. zopfli, brotli).