Skip to content

Commit

Permalink
git-p4: support multiple depot paths in p4 submit
Browse files Browse the repository at this point in the history
When submitting from a repository that was cloned using a client spec,
use the full list of paths when ruling out files that are outside the
view.  This fixes a bug where only files pertaining to the first path
would be included in the p4 submit.

Signed-off-by: Sam Hocevar <sam@hocevar.net>
Signed-off-by: Luke Diamand <luke@diamand.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
samhocevar authored and gitster committed Dec 21, 2015
1 parent 785e70f commit cbc6924
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions git-p4.py
Original file line number Diff line number Diff line change
Expand Up @@ -1458,6 +1458,8 @@ def prepareSubmitTemplate(self):
Remove lines in the Files section that show changes to files
outside the depot path we're committing into."""

[upstream, settings] = findUpstreamBranchPoint()

template = ""
inFilesSection = False
for line in p4_read_pipe_lines(['change', '-o']):
Expand All @@ -1470,8 +1472,13 @@ def prepareSubmitTemplate(self):
lastTab = path.rfind("\t")
if lastTab != -1:
path = path[:lastTab]
if not p4PathStartsWith(path, self.depotPath):
continue
if settings.has_key('depot-paths'):
if not [p for p in settings['depot-paths']
if p4PathStartsWith(path, p)]:
continue
else:
if not p4PathStartsWith(path, self.depotPath):
continue
else:
inFilesSection = False
else:
Expand Down

0 comments on commit cbc6924

Please sign in to comment.