Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor c++ code: #55

Merged
merged 6 commits into from
Dec 29, 2020
Merged

refactor c++ code: #55

merged 6 commits into from
Dec 29, 2020

Conversation

dselivanov
Copy link
Owner

move more functions to header files, change file naming

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #55 (65ebbec) into master (fd41b3f) will increase coverage by 0.40%.
The diff coverage is 70.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   74.17%   74.58%   +0.40%     
==========================================
  Files          27       33       +6     
  Lines        2122     2105      -17     
==========================================
- Hits         1574     1570       -4     
+ Misses        548      535      -13     
Impacted Files Coverage Δ
src/kmeans.cpp 0.00% <0.00%> (ø)
src/nnls.cpp 0.00% <0.00%> (ø)
src/rankmf.cpp 0.00% <0.00%> (ø)
inst/include/mapped_csr.hpp 53.84% <53.84%> (ø)
inst/include/wrmf_utils.hpp 84.37% <84.37%> (ø)
src/utils.cpp 79.31% <87.50%> (+0.90%) ⬆️
src/matrix_csr.cpp 93.07% <87.71%> (ø)
src/matrix_top_product.cpp 94.44% <88.88%> (ø)
src/factorization_machine.cpp 93.33% <93.33%> (ø)
src/FTRL.cpp 95.74% <93.75%> (+3.43%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd41b3f...65ebbec. Read the comment docs.

@dselivanov dselivanov merged commit 9549d6d into master Dec 29, 2020
@dselivanov dselivanov deleted the cpp-refactor branch December 31, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant