Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to MatrixExtra #68

Merged
merged 1 commit into from
May 22, 2021
Merged

Conversation

david-cortes
Copy link
Contributor

Package MatrixExtra is now on CRAN and has passed most of the CRAN checks:
https://cran.r-project.org/web/checks/check_results_MatrixExtra.html

This PR removes the functionality which is now in MatrixExtra, importing the package instead. I don't know which operators (if any) specifically are required, so I added it under Depends so as to load the whole namespace.

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #68 (9cf18c2) into master (6e72fed) will decrease coverage by 4.22%.
The diff coverage is 73.33%.

❗ Current head 9cf18c2 differs from pull request most recent head 07bd49f. Consider uploading reports for the commit 07bd49f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   74.87%   70.65%   -4.23%     
==========================================
  Files          14       13       -1     
  Lines        1194      995     -199     
==========================================
- Hits          894      703     -191     
+ Misses        300      292       -8     
Impacted Files Coverage Δ
R/model_WRMF.R 75.95% <73.33%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e72fed...07bd49f. Read the comment docs.

@dselivanov dselivanov merged commit 08609e6 into dselivanov:master May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants