Fixes for OpenMP limit options and detection #78
Merged
+12
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omp_get_max_threads() will consult the default number of threads for the current nested parallelism layer, which is set either by the runtime or from the OMP_NUM_THREADS environment variable. omp_get_thread_limit() will consult the separate limit on the total number of threads, set by the OMP_THREAD_LIMIT environment variable.
Instead of resetting it unconditionally to the automatically detected number of threads, let the user pre-set the option to their desired value (overriding everything). Additionally, let detect_number_omp_threads() rely on the OpenMP runtime to parse the OMP_NUM_THREADS and OMP_THREAD_LIMIT environment variables instead of parsing them manually. In particular, a valid OMP_NUM_THREADS could contain multiple integers representing different levels of nested parallelism.
|
Thanks for the issue and for the solution! |
|
On CRAN now |
|
Thank you too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #77.
Use
omp_get_max_threadsandomp_get_thread_limitto let the OpenMP runtime parse theOMP_NUM_THREADSandOMP_THREAD_LIMITenvironment variables. Only set thersparse_omp_threadsoption if it is not already set.