Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to popModal. #166

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Fix call to popModal. #166

merged 2 commits into from
Apr 11, 2022

Conversation

dsheeler
Copy link
Owner

gnome 42 support #164

@p91paul
Copy link
Collaborator

p91paul commented Apr 11, 2022

did you test this with gnome 40 and 41? otherwise please drop older versions in metadata.json. Thanks!

@dsheeler
Copy link
Owner Author

I did not test on 40/41. I'll drop them

@Neo-29
Copy link

Neo-29 commented Apr 11, 2022

can confirm it worked on 41...i even bypassed the version first without issues
it's 42 related

@dsheeler
Copy link
Owner Author

@Neo-29, It worked in 40 and 41 before my fix for 42, but I haven't tested if the fix for 42 breaks 40 or 41.

@Neo-29
Copy link

Neo-29 commented Apr 11, 2022

I guess your fix is not yet pushed on gnome extension?
Should I build it from source?

I know there's a package on AUR too.. Don't know if it follows the git update.

@dsheeler
Copy link
Owner Author

It's still not in the main branch, but if you have github command line client, if you clone the repository and run

$ gh pr checkout 166

you can get the code

@p91paul p91paul merged commit 35218f1 into dsheeler:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants