fixed animation error after full rotate of all apps

[N7K5]

There were two bugs. one where the windows are not drawn exactly how they should after one full rotate of all apps.
and second is closing using f4 shows animation as if two apps are closed.

[N7K5]

See the before and after video for better understanding... befire all the windows were drawn one over another after a full rotation..

rec__-2022-06-05_04.21.24.mp4

.

[dsheeler]

Awesome! The flip thing was something I was going to look into next. Thanks!

About the f4 bug: I don't know why it was calling the stuff you commented out, so I don't understand the implications. Do you get what's going on there?

[N7K5]

Well, Not that i exactly undersstand,

but, what I think happening is, there are some windows which doesnot closes directly when you press alt+f4 (like interactive python terminal, pressing alt+f4 shows an warning of you really want to close). so, the commented out block checks if the window is really closed after some timeout (100 ms) by calling _checkDestroyed, but that block of code for some reason calls _removeDestroyedWindow!!! which shows animation of removing the next window ( as this._windows[this._currentIndex] is now the next window after removing the current window)

[dsheeler]

Gotcha. Could you remove the commented stuff and commit? Then I'll merge.

[dsheeler]

I fiddled around with things and got the flip to order the windows properly (avoiding the jump to proper ordering at the end

simplescreenrecorder-2022-06-04_19.22.40.mp4

)

[N7K5]

Oh, it looks good... thanks.

[dsheeler]

Ahh, there was a miscommunication: I meant for you to delete the commented lines not to uncomment them. Sorry for the confusion! The reason to delete instead of comment is that you don't want commented lines when you can safely remove the lines but still be able to reference the old code in git

Also, could you revert the z-ordering fix you added? The solution I have does something different.

[dsheeler]

THANKS!