Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cat command #144

Merged
merged 6 commits into from
Jun 4, 2023
Merged

feat: add cat command #144

merged 6 commits into from
Jun 4, 2023

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented May 26, 2023

No description provided.

@sigmaSd
Copy link
Contributor Author

sigmaSd commented May 27, 2023

also what about putting those tests file under their own folder, they kind of clatter the view

dsherret
dsherret approved these changes Jun 4, 2023
View reviewed changes
Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit f108c11 into dsherret:main Jun 4, 2023
@dsherret
Copy link
Owner

dsherret commented Jun 4, 2023 •
edited
Loading

also what about putting those tests file under their own folder, they kind of clatter the view

I prefer having them right beside the files that are being tested. It helps encourage adding or modifying tests when changing the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigmaSd @dsherret