Skip to content
This repository has been archived by the owner on Oct 15, 2018. It is now read-only.

Remove cache for TypeExpressionDefinition #154

Closed
dsherret opened this issue May 13, 2016 · 2 comments
Closed

Remove cache for TypeExpressionDefinition #154

dsherret opened this issue May 13, 2016 · 2 comments
Labels
Milestone

Comments

@dsherret
Copy link
Owner

dsherret commented May 13, 2016

This made more sense when the library was first made, but now it doesn't because there's code generation. Every TypeExpressionDefinition should be unique.

For example, right now every string is a single TypeExpressionDefinition so when you change one string's text it changes all of them.

@dsherret dsherret added the ast label May 13, 2016
@dsherret dsherret added this to the Version 3.1 milestone May 13, 2016
@dsherret dsherret changed the title Remove cache on types Remove cache for TypeExpressionDefinition May 13, 2016
@dsherret
Copy link
Owner Author

dsherret commented May 13, 2016

Ahhh... well actually now I see this cache is very important because if it doesn't exist it will actually go on forever. I'm thinking for code generation that people should be encouraged to use the manipulation methods ex. setTypeExpression. Problem is that hasn't been implemented yet (#135), but what was found out in this issue should be taken into consideration for sure when implementing that.

Edit: No, not true.

@dsherret dsherret removed this from the Version 3.1 milestone May 13, 2016
@dsherret dsherret removed the wontfix label May 13, 2016
@dsherret dsherret added this to the Version 3.1 milestone May 13, 2016
@dsherret
Copy link
Owner Author

dsherret commented May 13, 2016

No, this needs to be fixed. It's really annoying to use this and change one part, but other places update.

@dsherret dsherret reopened this May 13, 2016
dsherret added a commit that referenced this issue May 13, 2016
#154 - Remove cache for type expressions (see TsFactory.ts for changes for that)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant