Moving docker container spinning to a fixture usable in jest #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fguitton
force-pushed
the
chore/docker-in-jest
branch
2 times, most recently
from
a20f520 to
7803f06
Compare
fguitton
force-pushed
the
chore/docker-in-jest
branch
from
7803f06 to
9431a1f
Compare
fguitton
force-pushed
the
chore/docker-in-jest
branch
from
25ae7eb to
bcf5999
Compare
sou-chon
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at trigger container creation from the jest setup directly. Because Jest
beforeAllasync handling is broken jestjs/jest#8688, jestjs/jest#9685, jestjs/jest#8442 containers are given a generous 10 second spin-up period in thebeforeAll. To support Windows more garcefully (particularly the handling of/inminio/minio:latest) the syntax ofchild_process.spawnis move to using array arguments.