Skip to content
This repository has been archived by the owner on Mar 29, 2021. It is now read-only.

Expanding list of citation styles crashes the Firefox #374

Closed
necxelos opened this issue Nov 1, 2017 · 9 comments
Closed

Expanding list of citation styles crashes the Firefox #374

necxelos opened this issue Nov 1, 2017 · 9 comments
Labels

Comments

@necxelos
Copy link

necxelos commented Nov 1, 2017

Hello

I'm the psychology researcher that tries to create his own webpage/blog. I have some basic web-design knowledge but mostly I rely on reverse-engineering snippets instead of writing my own code. I use Wordpress with probably the most popular Theme out there - X Theme from Themeco. I also use Firefox as my first choice for browsing the internet and working on the site.

Enough about me. The issue is:

  • I installed Your plugin, which seemed to perfectly fit into my needs.
  • I created testing site in my localhost environement.
  • I installed Your plugin and tried to change default styling via settings dropdown list of 1300 styles.
  • Firefox crashes (technically stops responding - I close it using Windows kill task everytime).
  • Works perfectly fine in Chrome at the same time using the same test site.

Thanks in advance for investigating this
necxelos

@dsifford
Copy link
Owner

dsifford commented Nov 1, 2017

Thanks for the report. What version of firefox is this happening in?

@necxelos
Copy link
Author

necxelos commented Nov 1, 2017

56.0.2 (64 bit) (newest version)

P.S. A sidenote: I failed to find APA (American Psychology Association) in Your styles list which is the most used Psychology styling in this science with some usage in other social sciences too. I can easily reproduce it using custom style though, so it's not as big of an issue as the crash :)

@dsifford
Copy link
Owner

dsifford commented Nov 1, 2017

Hmm... I'll have to check it out and see if I can reproduce. I'll try to take a look at it this weekend.

Also, APA is definitely there. If you're using the search feature on the reference list itself, the fuzzy matching is a bit wonky. Try typing exactly "American Psychological Association" to see if that works... Typing "Psychology" rather than "Psychological" likely causes it to not match.

@dsifford dsifford added the bug label Nov 1, 2017
@necxelos
Copy link
Author

necxelos commented Nov 1, 2017

My bad.
Indeed APA is there (all editions in fact).

I assumed it's alphabetically sorted, but things starting with "American" aren't. American Psychologist is alone between Americal Political Science Review and American Review of Canadian Studies, APA is between AORN and APCBEE and everything else is in proper alphabetical order elsewhere :)

Am I correct that it's due to the fact that "hidden/coded" names by which those are sorted are different from what end user sees?

Anyway thank You very much for insanely quick response :)

@dsifford
Copy link
Owner

dsifford commented Nov 1, 2017

No problem. Yeah, ordering gets shuffled based on match rank on the reference list search box. A fully alphabetical list can be found on the options page.

@necxelos
Copy link
Author

necxelos commented Nov 1, 2017

If You mean:
Backend > Settings > Academic Blogger's Toolkit > Default Citation Style
...than it's not sorted properly there either. I was talking about this part in my previous post (I just installed and launched Chrome and did it there for the sake of testing).

Most likely APA is sorted under A>P rather than A>M, even though visually full name is given and using keyboard to search through this list uses full name too. Matter of standarizing sorting by the looks of it. Some are sorted by full name, others are sorted by abbreviation. If I may suggest, You should sort all by full names and show all in full names to avoid the confusion.

Good luck and hear You soon
Feel free to let me now here after weekend if You were able to reproduce the crash

@dsifford
Copy link
Owner

dsifford commented Nov 1, 2017

Ah, I see.. It's likely sorted by the unique ID, rather than by the label... That's a mistake, I'll adjust that too...

FYI: All the styles are pulled directly from here: https://github.com/citation-style-language/styles -- The filenames you see listed in that repo are (likely) the sort order of the styles in the select box.

@dsifford
Copy link
Owner

dsifford commented Dec 9, 2017

@necxelos Circling back to this issue finally. Is this crash still affecting you? Can you confirm that the crash occurs simply when toggling the list of citation styles in the reference list?

@dsifford
Copy link
Owner

Haven't heard back. Assuming this has been resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants