Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push notifications for Notify My Android / Prowl (iOS) #152

Closed
jeroenpeters1986 opened this issue Nov 20, 2016 · 9 comments
Closed

Push notifications for Notify My Android / Prowl (iOS) #152

jeroenpeters1986 opened this issue Nov 20, 2016 · 9 comments
Assignees
Milestone

Comments

@jeroenpeters1986
Copy link
Collaborator

jeroenpeters1986 commented Nov 20, 2016

DSMR Reader great for pulling information, even with customizable reports and all. I think it might also be a good addition to have just little summarized daily usage-notifications being pushed to your phone.

Since Android and iOS are the most popular mobile platforms, I'd like to propose NotifyMyAndroid (for Android) and Prowl (for iOS).

@dennissiemensma
Copy link
Member

I've created a branch 152-push-notifications for your changes. Can you try creating a pull request to that specific branch?

See https://help.github.com/articles/creating-a-pull-request/

@dennissiemensma
Copy link
Member

After all it seems to be merged, Travis is now checking it in:
https://travis-ci.org/dennissiemensma/dsmr-reader/builds/177738832

@dennissiemensma dennissiemensma added this to the 1.4 milestone Nov 21, 2016
@dennissiemensma dennissiemensma self-assigned this Nov 21, 2016
dennissiemensma added a commit that referenced this issue Nov 21, 2016
dennissiemensma added a commit that referenced this issue Nov 21, 2016
dennissiemensma added a commit that referenced this issue Nov 24, 2016
@dennissiemensma
Copy link
Member

I have fixed the typo you found in 9bd9bfb

@jeroenpeters1986
Copy link
Collaborator Author

Ha, you were ahead of me, I was planning to do that tonight. Good to see that it's fixed :)

dennissiemensma added a commit that referenced this issue Nov 24, 2016
dennissiemensma added a commit that referenced this issue Nov 24, 2016
dennissiemensma added a commit that referenced this issue Nov 24, 2016
@dennissiemensma dennissiemensma changed the title Push notifications Push notifications for Notify My Android / Prowl (iOS) Nov 24, 2016
@dennissiemensma
Copy link
Member

I've tested this now and it likes like a charm :]

I added some text formatting because my first notification was showing and electricity usage of 5.3439999999999999. Now this (and the total prices + gas) will be rounded to two decimals.

@dennissiemensma
Copy link
Member

Merged to development as https://travis-ci.org/dennissiemensma/dsmr-reader/builds/178703214 succeeded.

@jeroenpeters1986
Copy link
Collaborator Author

Cool 👍

@dennissiemensma
Copy link
Member

I just thought of the situation of some users not having their gas read at all. I've added a test for this in 8ecfcc2 (using existing tests, but altering the loaded fixtures) to simulate this.

And as my own 'formatting' addition crashed, I've fixed that as well.

@dennissiemensma
Copy link
Member

The release containing your pull requests has just been released:
https://github.com/dennissiemensma/dsmr-reader/releases/tag/v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants