Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required login for dismissal of in-app notifications #179

Closed
dennissiemensma opened this issue Dec 15, 2016 · 2 comments
Closed

Remove required login for dismissal of in-app notifications #179

dennissiemensma opened this issue Dec 15, 2016 · 2 comments
Assignees
Milestone

Comments

@dennissiemensma
Copy link
Member

Someone mentioned me about the implementation of the in-app notifications. Currently an admin login is required to dismiss/delete them, but that doesn't make sense.

The reason for it is that public instances won't allow others to mark these notifications read. But it does seems unneeded, as any admins will check the dashboard after each upgrade anyway.

So I'll:

  • Remove the login-required check.
  • Convert them to XHR calls.
@dennissiemensma
Copy link
Member Author

Reported by @sdeleeuw

@dennissiemensma
Copy link
Member Author

Done, built XHR as well. Merged to development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant