iOS Web App: prevent same-window links from being opened externally #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, iOS Web Apps open any link (`<a>` tag) in an external browser. This happens even when the `target` attribute isn't set to `_blank`. This change prevents links targetting the same window from being opened externally. They are instead opened within the Web App itself.
Codecov Report
@@ Coverage Diff @@
## development #398 +/- ##
==========================================
Coverage 100% 100%
==========================================
Files 96 96
Lines 2239 2239
Branches 177 177
==========================================
Hits 2239 2239 |
dennissiemensma
requested changes
Dec 9, 2017
|
Ik heb de wijziging doorgevoerd. 😉 |
dennissiemensma
approved these changes
Dec 9, 2017
|
Thanks! |
dennissiemensma
added a commit
that referenced
this pull request
Dec 9, 2017
|
Graag gedaan! |
dennissiemensma
added a commit
that referenced
this pull request
Dec 10, 2017
|
Zojuist uitgebracht in release v1.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, iOS Web Apps open any link (
<a>tag) in an external browser. This happens even when thetargetattribute isn't set to_blank.This change prevents links targetting the same window from being opened externally. They are instead opened within the Web App itself.