WIP Add accountability to issue edits #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archive and fingerprint previous issue edit for faster rendering of single issue history. Signature on fingerprint. All optional. Commit as object for feature discussion.
nolash
changed the title
dspinellis
reviewed
Jan 13, 2022
There was a problem hiding this comment.
Thank you for the contribution! Not sure how this will make the history faster. Isn't git log on the issue's directory fast enough?
I also don't understand how this is / can-be a plugin, given that you call directly archive_by_path .
I added some comments for improving the code.
| # signature message is the signature of the TAR archive wrapping the three items, added in the sequence defined by archive_by_path | ||
| gpg_key=$(git config --get user.signingKey) | ||
| if [ -z "$gpg_key" ]; then | ||
| echo "no gpg key" |
| opt_archive=1 | ||
| opt_sign=1 | ||
|
|
||
| sig_by_state() { |
There was a problem hiding this comment.
Please add a comment describing what this function does. Consider also expanding sig.
| h=$(sha1sum a.tar.gz | awk '{ print $1; }') | ||
| popd | ||
| mv -v $t/a.tar.gz $path/${now}_${h}.tar.gz | ||
| sig_by_state $1 $h |
There was a problem hiding this comment.
Please eliminate the -v options to tar, cp, mv. By default the operation should be silent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks, this looks perfect for a small, personal issues use-case.
Before I'd start using this, I would need some things:
The current state of this PR is meant as a proposal for an initial albeit brittle implementation of this feature.
You'll find my contacts via my profile if you wanna discuss off-platform :)