Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weaken numpy requirement #195

Closed
wants to merge 1 commit into from
Closed

Conversation

diehlbw
Copy link

@diehlbw diehlbw commented Jul 2, 2024

Addresses #183 by weakening the pinning on numpy.

While I agree in spirit with the comment on not having strict pinnings I tried not to increase scope of changes more than necessary to hopefully reduce back-and-forth

@diehlbw
Copy link
Author

diehlbw commented Jul 30, 2024

@sgpjesus - what is the process to get feedback on this? is it something that can be considered?

@sgpjesus
Copy link
Collaborator

Hi @diehlbw, sorry for the delay. The process is still not very defined yet, for now I wanted to finish the merge request on using poetry before advancing with any dependency changes!

@sgpjesus
Copy link
Collaborator

Hi @diehlbw, Thank you for your PR. We are working on extending the unit tests; it would be easier to see if weakening the numpy requirement would affect anything after that. Still, I ask you to pull the changes in Master, and update the pyproject.toml file.

@diehlbw
Copy link
Author

diehlbw commented Sep 11, 2024

Closing since this is effectively fixed with the latest commit.

Also want to convey some considerations that non-trivial updates to requirements files should often be considered breaking changes (ie correspond to major version bump, or at least a minor one depending on your update patterns).
Environments that had been constructed to work with the old v1.0.0, may not work if other packages are pinned/constrained; much less code itself.

@diehlbw diehlbw closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants