-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Multi-Variate MODE #1184
Comments
…anch, made minor changes to get it compiling again.
…ol_calc library. Also in tokenizer.cc replace a switch statement with if-elseif-else logic to avoid the use of constexpr which may impact the flags needed to compile MET. Don't want to introduce C++11 features this late in the development cycle for version 10.1.0 since I don't want existing MET compilation scripts to no longer work.
…t when printing the usage statement. Update the copyright dates to 2022.
…gic with multivar_logic since that's what the code is looking for.
…orporated implemented following the standard Makefile conventions.
Reopening this issue. Merging in the multi-variate MODE PR into develop triggered a testing workflow run for METplus. But 6 of the 44 testing groups failed with runtime errors from MODE. So while the changes didn't break the MET regression tests, they did break the METplus ones. All of the MODE runtime errors look something like this:
Here's why... the logic on this line is insufficient:
It assumes that the user-specified config file is always the 4-th item on the command line. However, METplus runs MODE like this (at least in all of the failed runs):
Having However the real fix it to use the CommandLine class the properly parse the command line. |
…. Also, remove stale commented out code.
A new MODE tool is to be created to perform arbitrary set operations
(union, intersection, difference, etc.) on objects generated by MODE.
The objects in general will be associated with different variables.
Object attributes (centroid, axis, etc.) will be computed for the resultant objects.
Matching and merging may be a later option.
This tool is to be tested on fields relevant for dryline identification
(gradient of temperature, gradient of specific humidity, etc.).
The output format of the new tool will be identical to that of MODE.
Account Key: 2700042 WPC
Related METplus issue: dtcenter/METplus#1516
The text was updated successfully, but these errors were encountered: