Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multivariate MODE to log it's output to a single log file. #1593

Closed
6 of 20 tasks
JohnHalleyGotway opened this issue Dec 3, 2020 · 2 comments · Fixed by #2779
Closed
6 of 20 tasks

Fix Multivariate MODE to log it's output to a single log file. #1593

JohnHalleyGotway opened this issue Dec 3, 2020 · 2 comments · Fixed by #2779
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle MET: Library Code priority: high High Priority requestor: NCAR National Center for Atmospheric Research type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

This task is closely related to MET #1283. If all Multivariate MODE functionality is run by a single process, then the logging issue effectively goes away.

MET #1184 was included in the met-10.0.0-beta2 release to add the multi-variate MODE option. This version of the code spawns new processes to execute individual calls to the standard MODE prior to combining the output into a super object. This task is to figure out how to handle the writing of a log file in this context. Since multiple processes are spawned, having them write to the same output log file is non-trivial.

Since the calls to MODE are done sequentially, consider adding a no-clobber option to the logger so that each call to single MODE can open and append to the same log file without overwriting it.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues required.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: library code requestor: NCAR National Center for Atmospheric Research alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Dec 3, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.0.0 milestone Dec 3, 2020
@JohnHalleyGotway JohnHalleyGotway changed the title Fix multi-variate MODE to log it's output to a single log file. Fix Multivariate MODE to log it's output to a single log file. Dec 3, 2020
@lindsayrblank lindsayrblank modified the milestones: MET 10.0.0, MET 10.1.0 Jan 27, 2021
@lindsayrblank lindsayrblank added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Jan 27, 2021
@TaraJensen TaraJensen added required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone and removed alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels May 20, 2021
@TaraJensen TaraJensen modified the milestones: MET 10.1.0, MET 11.0.0 Nov 4, 2021
@JohnHalleyGotway
Copy link
Collaborator Author

Please note that any changes to how Multi-Variate MODE should be run based on this issue should be noted on the METplus issue for the Multi-Variate MODE wrapper (dtcenter/METplus#1585).

@JohnHalleyGotway JohnHalleyGotway added priority: high High Priority and removed priority: high labels May 9, 2022
@JohnHalleyGotway JohnHalleyGotway removed the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label Sep 21, 2022
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Sep 21, 2022
@davidalbo davidalbo linked a pull request Feb 8, 2024 that will close this issue
14 tasks
@davidalbo
Copy link
Contributor

Closing this issue as it was fixed by refactoring multivariate mode to not spawn multiple instance of traditional mode. The newer design does not do this, it does sequential steps that depend on each other (so the original design no longer made sense).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle MET: Library Code priority: high High Priority requestor: NCAR National Center for Atmospheric Research type: enhancement Improve something that it is currently doing
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

5 participants