Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default ASCII2NC message_type_map configuration option for Little R input data #2487

Closed
8 of 21 tasks
CPKalb opened this issue Mar 14, 2023 · 3 comments · Fixed by #2562
Closed
8 of 21 tasks
Assignees
Labels
MET: PreProcessing Tools (Point) priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@CPKalb
Copy link

CPKalb commented Mar 14, 2023

Describe the Enhancement

When running ascii2nc on the file qc_out_2023-03-11_18:00:00.0000.txt, warnings appear:
WARNING: LittleRHandler::_readObservations() -> Storing message type as "FM-18X_BUOY" for unexpected report type "FM-18X BUOY".
WARNING:
WARNING:
WARNING: LittleRHandler::_readObservations() -> Storing message type as "FM-16_SPECI" for unexpected report type "FM-16 SPECI".
WARNING:
WARNING:
WARNING: LittleRHandler::_readObservations() -> Storing message type as "FM-97_AMDAR" for unexpected report type "FM-97 AMDAR".

The ascii2nc little r dictionary needs to be updated for these additional report types. The command to produce these warnings is:
ascii2nc qc_out_2023-03-11_18:00:00.0000 test.nc -format little_r

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@CPKalb CPKalb added type: enhancement Improve something that it is currently doing alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Mar 14, 2023
@JohnHalleyGotway
Copy link
Collaborator

@CPKalb good news. All that is required here is an update to the ascii2nc configuration file. Please take a look at the message_type_map dictionary on this line:

message_type_map = [

Please try re-running ascii2nc with an updated configuration file and propose the exact changes you'd like to see in the ascii2nc configuration file.

@CPKalb
Copy link
Author

CPKalb commented Mar 14, 2023

Awesome, I will give this a try for our UAE data!

@JohnHalleyGotway JohnHalleyGotway added priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory MET: PreProcessing Tools (Point) and removed alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Mar 14, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Mar 14, 2023
@CPKalb
Copy link
Author

CPKalb commented Mar 14, 2023

I've updated the dictionary in the copy on atmosphere, and this has removed all the warnings:

message_type_map = [
{ key = "FM-12 SYNOP"; val = "ADPSFC"; },
{ key = "FM-13 SHIP"; val = "SFCSHP"; },
{ key = "FM-15 METAR"; val = "ADPSFC"; },
{ key = "FM-16 SPECI"; val = "ADPSFC"; },
{ key = "FM-18 BUOY"; val = "SFCSHP"; },
{ key = "FM-18X BUOY"; val = "SFCSHP"; },
{ key = "FM-281 QSCAT"; val = "ASCATW"; },
{ key = "FM-32 PILOT"; val = "ADPUPA"; },
{ key = "FM-35 TEMP"; val = "ADPUPA"; },
{ key = "FM-88 SATOB"; val = "SATWND"; },
{ key = "FM-97 ACARS"; val = "AIRCFT"; },
{ key = "FM-97 AMDAR"; val = "AIRCFT"; }
];

Should I update it somewhere in MET?

@JohnHalleyGotway JohnHalleyGotway added the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label May 18, 2023
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED MORE DEFINITION Not yet actionable, additional definition required label Jun 6, 2023
This was linked to pull requests Jun 6, 2023
@JohnHalleyGotway JohnHalleyGotway removed a link to a pull request Jun 9, 2023
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Jun 9, 2023
@JohnHalleyGotway JohnHalleyGotway removed a link to a pull request Jun 9, 2023
15 tasks
@JohnHalleyGotway JohnHalleyGotway linked a pull request Jun 9, 2023 that will close this issue
@JohnHalleyGotway JohnHalleyGotway removed a link to a pull request Jun 9, 2023
@JohnHalleyGotway JohnHalleyGotway linked a pull request Jun 9, 2023 that will close this issue
15 tasks
JohnHalleyGotway added a commit that referenced this issue Jun 9, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Update Ascii2NC Little R dictionary Update the default ASCII2NC message_type_map configuration option for Little R input data Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: PreProcessing Tools (Point) priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants