-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Refine support for LAEA grids via NetCDF and GRIB2 files #2565
Comments
@mpm-meto and @robdarvell, @rgbullock is working on this issue. He is using a MetOffice data file for testing that is centered on the United Kingdom. I am wondering if you perhaps have a sample data file that's further away from the prime meridian with which he could also test? For example, in the past you send us data centered over India. Can you provide a sample LAEA CF-Compliant NetCDF file that covers the India domain? |
I can ask. Perhaps UM partners now running IMPROVER will have some sample data but we don't have any LAEA data over other parts of the world. |
OK, thanks for checking. We'll do the best we can with UK LAEA NetCDF sample data we have. If you do get your hands on NetCDF data for additional LAEA domains, please pass it along. |
… from CF-compliant NetCDF files. Note that the GRIB2 parameters remain the primary method for defining LAEA grids. Randy uses the NetCDF parameters to instantiate the GRIB2 data structure.
… adopting this as the standard way of initializing an LAEA grid.
…c to dump the grid data structs that are parsed, just like we do for other file formats (GRIB2, MET NetCDF, ...)
…nd error out if they're non-zero.
…ide semi_major_axis and semi_minor_axis by 2.
…place the sample MetOffice data over the UK.
…rt-coming in the grib2c library in handling negative longitude values. Define and call a utility function to reprocess the bytes and check for negative values.
…GHA build artifacts. After using docker to build the image, run a docker copy command to copy out the compliation logs.
Note that I renamed this issue to clarify that 2 changes are needed:
For the latter, the MET-11.1.0-rc1 version does not properly parse longitudes from the LAEA GRIB2 metadata. The problem lies in the GRIB2C library which MET uses to retrieve that metadata. In the sample GRIB2 files over the United Kingdom, the 2 longitudes defining the LAEA grid have negative values. The GRIB2C library does not properly parse that negative value. Both 1. and 2. are now fixed. For 2., MET now reprocesses the 4 bytes which constitute the value and reprocess them looking for a negative. |
Describe the Problem
Development for #1693 ADDED support for reading LAEA grids from GRIB2 files. However, it also REMOVED the existing support for reading LAEA grids from CF-compliant NetCDF files. As such, we commented out the existing unit test that tested that functionality (see
<test name="plot_data_plane_LAEA_NCCF">
in unit_plot_data_plane.xml).This task is to restore that support for reading LAEA data from CF-compliant NetCDF files. Recommend paying careful attention to Lambert azimuthal equal area documentation. And please remember to uncomment the
plot_data_plane_LAEA_NCCF
unit test mentioned above.Only need to fix this for the
develop
branch prior to the MET-11.1.0 release.Expected Behavior
Support LAEA grids read from both GRIB2 and CF-complaint NetCDF files.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
Labels
Projects and Milestone
Define Related Issue(s)
Consider the impact to the other METplus components.
No impacts.
Bugfix Checklist
See the METplus Workflow for details.
Branch name:
bugfix_<Issue Number>_main_<Version>_<Description>
Pull request:
bugfix <Issue Number> main_<Version> <Description>
Select: Reviewer(s) and Development issue
Select: Organization level software support Project for the current coordinated release
Select: Milestone as the next bugfix version
Branch name:
bugfix_<Issue Number>_develop_<Description>
Pull request:
bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
The text was updated successfully, but these errors were encountered: