Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the unit test diff logic to handle SEEPS, SEEPS_MPR, and MODE CTS line type updates #2665

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Aug 22, 2023 · 0 comments · Fixed by #2668
Closed
8 of 21 tasks
Labels
component: testing Software testing issue priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Aug 22, 2023

Describe the Task

The SEEPS and SEEPS_MPR line types were added in MET version 11.0.0 but never added to the differencing logic for the MET unit tests. While that differencing logic will be replaced by a python version, this is an easy issue to add these line types to the existing logic so that it is available to be ported over. Only need to update the develop branch but add SEEPS and SEEP_MPR entries to the header table files for 11.0.0, 11.1.0, and the upcoming 12.0.0.

Note that 7 new columns are also added to the MODE CTS output line type for 12.0.0. However, the column header table files have not yet been updated to reflect those changes.

Time Estimate

1 hour

Sub-Issues

Consider breaking the task down into sub-issues.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added component: testing Software testing issue type: task An actionable item of work priority: medium Medium Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team labels Aug 22, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Aug 22, 2023
@JohnHalleyGotway JohnHalleyGotway moved this to 🏗 In progress in MET-12.0.0 Development Aug 22, 2023
JohnHalleyGotway added a commit that referenced this issue Aug 23, 2023
JohnHalleyGotway added a commit that referenced this issue Aug 23, 2023
@JohnHalleyGotway JohnHalleyGotway linked a pull request Aug 23, 2023 that will close this issue
15 tasks
@JohnHalleyGotway JohnHalleyGotway changed the title Add SEEPS and SEEPS_MPR line types to the unit test diff logic Update the unit test diff logic to handle SEEPS, SEEPS_MPR, and MODE CTS line type updates Aug 23, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 🏗 In progress to ✅ Done in MET-12.0.0 Development Aug 23, 2023
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: testing Software testing issue priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

1 participant