Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance TC-Pairs to read hurricane model diagnostic files (e.g. SHIPS) and TC-Stat to filter the new data #392

Closed
20 of 24 tasks
dwfncar opened this issue Apr 18, 2014 · 20 comments · Fixed by #2315
Closed
20 of 24 tasks
Assignees
Labels
MET: Tropical Cyclone Tools priority: high High Priority requestor: DTC/PAS DTC Physics Across Scales T&E requestor: NOAA/HFIP NOAA Hurricane Forecast Improvement Project
Milestone

Comments

@dwfncar
Copy link
Contributor

dwfncar commented Apr 18, 2014

Describe the Enhancement

This task is requested by Paul Kucera and will be done to support the HFIP evaluations.

Currently, the MET-TC tools only handle hurricane ATCF files. This task is to add support for parsing/using hurricane model diagnostic files. The diagnostic files are ASCII and can be produced for each model/storm/initialization time. The diagnostic file contains track information for each lead time, just like the ATCF files, but also include many derived quantities, like shear and upper level quantities averaged over the storm area.

Enhance TC-Pairs to read TC diagnostics data in two different file formats:

ACTION: After parsing this diagnostics data and finding a match for the model track currently being evaluated, need to decide how to write the diagnostics to the output.

Consider either tacking on the diagnostics data to the end of the existing TCMPR line type. Or consider writing a new TCDIAG line type containing only the diagnostics values. This decision should be driven by downstream needs of METdatadb and METviewer. What makes the most sense since the number and type of diagnostic values can change? We wouldn't have a fixed set of output columns. They would vary based on the user configuration of the TC-Diag tool.

Time Estimate

1 week

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2770043

Define the Metadata

Assignee

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

This task is requested by Paul Kucera and will be done to support the HFIP evaluations.


Currently, the MET-TC tools only handle hurricane ATCF files. This task is to add support for parsing/using hurricane model diagnostic files. The diagnostic files are ASCII and can be produced for each model/storm/initialization time. The diagnostic file contains track information for each lead time, just like the ATCF files, but also include many derived quantities, like shear and upper level quantities averaged over the storm area.

Define new classes in the vx_tc_util library for reading this diagnostic data. Suggest including the ability to write the diagnostic data to a file. This could be a new line type, like TCMPR but maybe TCDIAG, for tropical cyclone diagnostics. The header columns would need to be the same as those in TCMPR.

The wrinkle here is that the contents of the diagnostic file can vary based on how the diagnostics were generated. So we wouldn't have a fixed set of output columns. Instead, after the header columns, the column names would indicate the contents.

(1) Suggest writing a new tool that just reads in a bunch of diagnostic files and writes them out to a single file. This would be a reformatting step and make it easier to process the diagnostic data.

(2) Suggest enhancing the tc_pairs tool to also read in the diagnostic files. For each ATCF track, look for a matching diagnostic track. Look in the tc_pairs config file at the user-specified list of diagnostic quantities to be included. Then tack those diagnostic quantities to the end of the line. Include support for short-cuts like "ALL" and partial string matching, like "p500" for 500mb quantities.

(3) Suggest enhancing the tc_stat tool to read the TCDIAG line type and filter the lines. Also enhance tc_stat to read the additional variable columns from the TC_MPR lines.

[MET-392] created by johnhg

@dwfncar
Copy link
Contributor Author

dwfncar commented Apr 23, 2018

This work was requested a second time by Paul Kucera and Mark Demaria at NHC. Funding will be allocated in 2018 for this. Here's some selections of emails about it...


From Paul...
The HFIP office said they have some funding to further develop MET-TC tools. In particular, NHC would like this feature added: stratify the track and intensity errors by vertical wind shear (and other variables like low-level humidity). Would you be able to give me a ball-park estimate of cost to add that feature? I will add that to my HFIP budget for this year.

From John...

Processing the gridded data files ourselves would open up a lot of flexibility... but would require that those gridded data files actually be present for each ATCF track ID being processed. It may also be slow to process gridded data for each forecast hour.

Using the diagnostic output would be faster in MET but would then require that the diagnostic tool be run on the gridded data sets. Perhaps we’d need to support that diagnostic tool to the broader community?

The real problem here is that the ATCF tracks do not contain enough diagnostic info... like wind shear. And there’s a few ways we could address that... from updating the output of the GFDL vortex tracker itself, to reading the existing diagnostic files, to generating those diagnostics directly in MET.

My first inclination would be to reimplement the diagnostic functionality as a new tool in MET (tc_diag)... to make it available and supportable. And then update tc_stat to read the output of both tc_pairs and tc_diag when doing its filtering. But let’s talk more about it next week.

Also, it would be really great to update METViewer to read/plot this track data as well, and replace the Rscripts we currently run!

From Paul...
I heard back from Mark. He suggested that we first use Kate's diagnostic files and/or the output from the operational SHIPS model. I am assuming that will be a bit more straightforward. by johnhg

@dwfncar
Copy link
Contributor Author

dwfncar commented Mar 20, 2019

Paul Kucera has identified funding for this work and would like it included after the met-8.1 release.


The funding for this ends July 2019, and the work could be coordinated with the tc-rmw and tc-gen enhancements.


Paul reiterated this on 2019/03/20.
by johnhg

@TaraJensen
Copy link
Contributor

Moved this into MET 10.1.0 development cycle during discussion with HAFS developers. They see this as a high priority.

@TaraJensen TaraJensen added the required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project label May 17, 2021
@jvigh
Copy link
Contributor

jvigh commented Aug 4, 2021

@TaraJensen @JohnHalleyGotway

Christopher Rozoff has now developed a more comprehensive suite of ensemble diagnostics which are similar to the SHIPS diagnostics. We are in the process of finalizing these. They will be in NetCDF format. We'd like to work with you to figure out what format they need to be in to be easily read by MET-TC (e.g., is CF-compliant sufficient?).

Paul's funding for his EnsRI/NHCvx projects will be ending Sep 30 (hard deadline). It might be possible to devote a bit of time to MET development -- we'd need to discuss with Paul.

@JohnHalleyGotway
Copy link
Collaborator

Had some discussions over email with @jvigh about this work. They are summarized below.

From Jonathan:
The format is being finalized right now by Chris Rozoff. Our goal is to make it as close as possible to being CF-compliant as possible, noting that many of the quantities may not have standard names or units that are included in the CF-standards.

From John HG:
While MET does currently read NetCDF files following the gridded CF-convention, it does not currently read any point observations following CF point convention. While CF is in wide usage for gridded data, it's less widely used for point data, to my knowledge. But there still may be some code that's reusable... like the parsing of date/time strings.

The TC-Pairs tool reads ATCF forecast track data and ATCF Best track data, and for each storm matches up their common track point. And for each fcst/Best track point pair, it computes along/cross/total track error and writes that to the output. The TC-Stat tool reads the TC-Pairs output, filters it in whatever way the user says, and then performs some analysis job on that data.

From Jonathan:
They are not gridded data. All of the diagnostic values are "storm-centric", meaning they apply to the storm environment or some aspect of the storm structure. For example, a key parameter would be environmental vertical wind shear. There could actually be several of these, but the idea is the same -- they are a value that represent the diagnostic quantity at a point in time (just like track position or intensity). So the existing logic of tcpairs should work well for this. It may need to be enhanced, say, to allow one to stratify verification results by weak, moderate, or strong vertical shear. Another example would the the Maximum Potential Intensity (MPI) of a storm, etc.

From John HG:
Great, thanks for clarifying. In my mind, we'd set it up so that...

  • the user specifies the source of one or more diagnostics files to be read on the tc_pairs command line
  • the user specifies the names of the diagnostic values in which they're interested in the tc_pairs configuration file
  • for each requested diagnostic, tc_pairs appends a new column of output to the existing tc_pairs output line type
  • for each track point, tc_pairs searches the diagnostic file(s) for the requested data and appends it to the end of each line
  • tc_stat is able to filter the output of tc_pairs by thresholding the values in the "extra" columns by name
    • for example: -column_thresh VERTICAL_SHEAR >100
    • that'd mean, only retain TCST lines from tc_pairs that have a column named VERTICAL_SHEAR at the end and that have a value > 100.

I think the main work will be writing code to parse the diagnostic info from NetCDF files into memory.

From Jonathan:
I'm pretty sure there won't be 80-100 hours available for this. But there could possibly be 30-60 h, if Paul wants to go this route. If Tara had other funds to leverage, it might work (if you think it's really an 80+ h task).

@JohnHalleyGotway
Copy link
Collaborator

Please find sample diagnostic data from Chris attached.
ida2021082700.tar.gz

JohnHalleyGotway added a commit that referenced this issue Oct 21, 2022
…e that is requested but is not actually present in the input data.
JohnHalleyGotway added a commit that referenced this issue Oct 22, 2022
…t specify the conversion function based on the diagnostic name or units string. If both are provided, the conversion function for the name takes precedence.
JohnHalleyGotway added a commit that referenced this issue Oct 25, 2022
… each read function. Improved handling of setting the Technique.
JohnHalleyGotway added a commit that referenced this issue Oct 25, 2022
JohnHalleyGotway added a commit that referenced this issue Oct 26, 2022
…nvert between strings and enumerated values.
JohnHalleyGotway added a commit that referenced this issue Oct 26, 2022
… tcdiag_convert_map with a single diag_convert_map.
JohnHalleyGotway added a commit that referenced this issue Oct 26, 2022
JohnHalleyGotway added a commit that referenced this issue Oct 26, 2022
…with:

tc_pairs_conf_info.h:118:60: error: '>>' should be '> >' within a nested template argument list
       std::map<DiagType,std::map<ConcatString,UserFunc_1Arg>> DiagConvertMap;
Adding the extra space to make the code compile in Docker.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Oct 26, 2022 that will close this issue
15 tasks
JohnHalleyGotway added a commit that referenced this issue Oct 26, 2022
…Also needed to refine the logic in track_info.cc.
JohnHalleyGotway added a commit that referenced this issue Oct 28, 2022
JohnHalleyGotway added a commit that referenced this issue Oct 28, 2022
…hanges enable LAT and LON values to be included on the TCDIAG line as requested in Jonathan's PR review. Note that the longitude values stored for the header are converted from degrees east to west (*-1) and rescaled to a standard range to match the track data. The LON values written to the TCDIAG line are NOT converted in this way. Figure its better to leave them as close to the input as possible. Also renamed the input test data directory from lsdiag to lsdiag_rt, figuing that we'll need add data for lsdiag_dev eventually.
@jvigh jvigh removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Nov 1, 2022
JohnHalleyGotway added a commit that referenced this issue Nov 3, 2022
* Initialze obs_data at constructor to avoid warninjg on building

* Initialze obs_data at constructor to avoid a warning by compiler

* #1824 ci-run-test Removed the duplicated code

* Feature 1810 expand asciitable (#2086)

* Feature 1583 skip_mean (#2090)

* Feature 1275 MODE Object Count (#2091)

* for #1275, fix issue with more than 1000 object for mode, ci-run-unit

* Per #1275, just deleting stale, commented-out code.

Co-authored-by: Randy Bullock <bullock@seneca.rap.ucar.edu>

* Feature 1184 dryline (#2088)

Co-authored-by: davidfillmore <fillmore.winslow.david@gmail.com>
Co-authored-by: rgbullock <bullock@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu>

* Feature 1184 replace_env (#2093)

* Feature 2092 v10.1.0-rc1 (#2094)

* Hotfix to the develop branch to fix the MODE Makefile for the MET-10.1.0-rc1 release.

* Second hotfix for the MODE Makefile in the develop branch.

* Feature 1844 docs (#2096)

* Feature 2097 v10.1.0 (#2099)

* Feature 2098 gen ens prod doc (#2100)

* update job control rules for GHA testing workflow to use version specific input data if running tests on main_v branch

* Migrating a small tweak added to the v10.1.0 release into the develop branch.

* Adding SonarQube location to development.seneca file.

* Bugfix #2102 develop initialize modified_hdr_typ (#2104)

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: johnhg <johnhg@ucar.edu>

* added logic to manually trigger a workflow via the GitHub… (develop) (#2109)

Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

* Feature update installation info (#2114)

* Updating configuration and modulefiles

* Removed jet files

* create DockerHub tag that ends with -lite to use when triggering the METplus testing workflow

* Bugfix #2115 develop Rotated LatLon (#2117)

* Feature 1950 sort station list (#2121)

* Update the top-level README file to list ioda2nc, but also to trigger GHA to run for this new main_v10.1-ref branch.

* Added bool Sorted variable, set to true or false in relevant functions. Updated sort() function. SL

* In parse_sid_mask(), added the line: mask_sid.sort(). SL

* Per issue #1950, put in some cout statements for testing. SL

* Per issue #1950, working in has() function, checking for Sort and put in initial cout's for testing. SL

* Per issue #1950: Cleaned up some cout (print) statements. Left one in there that is commented out for future testing. SL

* Per issue #1950: modified has() function. Added lower_bound search for sorted arrays. Left some print (cout) statements in there for further testing. SL

* Per issue #1950: In has(), I commented out the print (cout) statements for time testing. SL

* added logic to manually trigger a workflow via the GitHub… (#2107)

* Per issue #1950, put back in some print (cout) statements for testing. SL

* Per issue #1950: in has() function, experimenting using the upper_bound() search instead of lower_bound() for sorted vectors. In progress. SL

* Per issue #1950: added a new has function that uses binary_search. Re-working the other has() functions related to this. SL

* Per issue #1950: re-worked original has(), basically reverted back to what it was...but it's now only used for unsorted vectors or for a case insensitive search. Cleaned up. SL

* Per issue #1950: in section that checks Obs Station Id in SID masking list, changed cout to a mlog (debug) statement. SL

* Per issue #1950: created new mask station id list (CONUS METARs) and modified the PointStatConfig_MASK_SID config file to use this list along with the existing lists. SL

* Per issue #1950: reverted back to orginal sid mask site-lists. SL

* Per issue #1950: checking in this site-list that was used for testing point_stat. SL

* Per issue #1950, modified and added better debugging to figure out current issue with ascii2nc. SL

* Per #1950, small tweak in ascii2nc to make it slightly more efficient. After adding the new obs varable name to the end of the list, we can compute var_index direclty without needing to call StringArray::has() a second time.

* Per #1950: removed mlog and cout print statements from has() functions. Cleaned up. SL

* Update met/src/basic/vx_log/string_array.cc

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update met/src/basic/vx_log/string_array.cc

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update met/src/basic/vx_log/string_array.cc

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update met/src/basic/vx_log/string_array.cc

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update met/src/basic/vx_log/string_array.cc

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update met/src/basic/vx_log/string_array.h

Co-authored-by: johnhg <johnhg@ucar.edu>

* Delete SID_CONUS.txt

* Delete SID_CONUS_times11.txt

Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>

* Bugfix #2118 develop grib1_rotll (#2130)

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>

* Bugfix 2123 nccf valid time (#2127)

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: johnhg <johnhg@ucar.edu>

* Feature #2132 version 11.0.0 (#2133)

* Bugfix #2106 develop gcc (#2135)

Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: johnhg <johnhg@ucar.edu>
Co-authored-by: Seth Linden <linden@kiowa.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: Randy Bullock <bullock@seneca.rap.ucar.edu>
Co-authored-by: davidfillmore <fillmore.winslow.david@gmail.com>
Co-authored-by: rgbullock <bullock@ucar.edu>
Co-authored-by: Seth Linden <linden@ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: John Halley Gotway <johnhg@seneca.rap.ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: mo-mglover <78152252+mo-mglover@users.noreply.github.com>
Co-authored-by: davidalbo <dave@ucar.edu>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu>

* Doc-only update to expliciltly list the maximum character lengths for variable-length strings passed to ascii2nc.

* Added pcp_combine -subtract example (#2153)

* Add testing and docs status badges.

* Feature #2152 poly_xy (#2154)

* #14 Using literal instead of numbers and make sure no overflow

* #14 Using literal instead of numbers

* #14 Added tmp_buf_size

* #14 Define n_kw_infos first

* #14 Using literal instead of numbers

* Bugfix #2148 develop misses (#2150)

* dtcenter/METplus-Internal#14 formatting code

* METplus-Internal #16 Added python scanning

* METplus-Internal #16 changed name

* METplus-Internal #16 initial release for python scanning

* METplus-Internalv#19 added maic.cc & main.h

* METplus-Internalv#19 renamed main to met_main and added get_tool_name

* METplus-Internalv#19 Initial release

* changing 'Linked issue' to 'Development issue'

* change Linked issue/Development issue ci-skip-all

* change Linked issue/Development issue ci-skip-all

* change Linked issue/Development issue ci-skip-all

* Feature 1920 repo (#2161)

* List line types that can be aggregated per dtcenter/METplus#1625

* Hotfix for the develop branch to correct a bad MET_TEST_BASE path that causes the nightly build to fail.

* Feature 2072 tc rmw winds (#2165)

* bug fix for NAN and for using missing data as if its not missing

* added parameters to control converting winds to tangential/radial components

* bug fixes

* Refactored to put wind conversion into it's own class TCRMW_WindConverter

* changed default for converting winds to TRUE, and put parameters for wind conversion into the unit test config files

* Per #2072, updating tc_rmw Makefile.in to compile new files.

* Per #2072, update to the output from the lex/yacc version on seneca.

* Changed Error to Warning in mlog messages, for consistency with MET conventions

* Removing commented out code.

* Per #2072, combine warnings spread across multiple lines into a single call to the logger. Replace references to ugrid/vgrid with u/v wind. Fix a typo and clean up some whitespace.

Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

* change Linked issue/Development issue ci-skip-all

* Bugfix #2173 develop shift_data_plane (#2175)

* Bugfix #2170 develop agg_ecnt (#2177)

* Feature 2022 anom corr to vcnt (#2171)

* Per #2022: Added ANOM_CORR, ANOM_CORR_BCL, ANOM_CORR_BCU to vcnt_columns. SL

* Per #2022: Added ANOM_CORR, ANOM_CORR_BCL, ANOM_CORR_BCU to write_vcnt_cols. SL

* Per #2022: Added ANOM_CORR to VL1L2Info. SL

* Per #2022: updated the VL1L2Info functions to initialize and compute ANOM_CORR. SL

* Per #2022: in calc_ncep_stats modified calculation for ANOM_CORR to check for bad data in the denominator first. SL

* Per #2022: for the VL1L2Info, changed all derived VCNT variables to be CIInfo objects (instead of doubles). SL

* Per #2022: making changes to VL1L2Info related to making all VCTN variables CIInfo objects. In progress. SL

* Per #2022: Added ANOM_CORR_UNCNTR. SL

* Per issue 2022: Modified functions in the VL1L2Info class to set the NCEP stat variables correctly since they are now CIInfo class memembers. SL

* Per issue 2022: Added ANOM_CORR_UNCNTR (_BCL, _BCU). SL

* Per issue 2022: modified write_vcnt_cols(), added ANOM_CORR_UNCNTR (_BCL, _BCU). SL

* Per issue #2022: updated write_vcnt_cols. VCNT variables are now CIInfo objects to have to .v for the value. SL

* Per issue #2022: In calc_ncep_stats, put in place-holder for ANOM_CORR.v value SL

* Per issue #2022: in calc_ncep_stats(), changed placeholder for ANOM_CORR. SL

* Per issue #2022: moved alpha initialization to the init_from_scratch() function. SL

* Per issue #2022: in calc_ncep_stats(), set ANOM_CORR to bad_data_double as a placeholder for now. SL

* Per issue #2022: in vcnt_cols(), added ANOM_CORR_NCL/NCU. SL

* Per issue #2022: in write_vcnt_cols(), added ANOM_CORR_NCL/NCU variables. SL

* Per #2022, adding new VCNT columns to the header table files, User's Guide documentation, and lining some code up more consistently.

* Per #2022, added FA_SPEED_BAR and OA_SPEEED_BAR to the VAL1L2 line type. Added code to compute the ANOM_CORR confidence interval. However, I still need to update the writing of the VCNT line type to set the alpha value and actually write the computed CI's.

* Per #2022, update the writing of the VCNT output line to write the alpha value and anomaly correlation CI's.

* Per #2022, update point_stat and grid_stat to allocate alpha values for VL1L2Info objects to store CI's.

* Per #2022, call VL1L2Info::zero_out() instead of clear() so that we don't throw away allocated alpha values.

* Per #2022, update the Point-Stat and Grid-Stat logic to include the number of alpha values when deciding how many VCNT lines to write.

* Per #2022, update the VL1L2Info::operator+= logic to copy over the allocated alpha values.

* Per #2022, enhance stat_analysis to support an aggregate_stat job type for VAL1L2->VCNT. This writes ANOM_CORR and ANOM_CORR_UNCNTR output columns. However, there are still things to address. The other stats should be written as NA instead of 0. Recommend changing the VL1L2Info::zero_out() function to intialize stat values to NA instead of 0. Need to update the docs to reflect this support. Also need to actually compute the parametric CI's for ANOM_CORR. Big picture, we should store the VCNT stats in a new VCNTInfo class... just like the SL1L2Info/CNTInfo setup. Storing the sums AND stats in the same VL1L2Info class is unnecessarily confusing.

* Per #2022, update Stat-Analysis docs to list VAL1L2 -> VCNT as a supported conversion type.

* Per #2022, when computing VL1L2Info CI's, n should be set to vacount rather than the number of input pairs.

* Per #2022, add a new call to Stat-Analysis to exercise the VAL1L2 to VCNT conversion.

* Per #2022, ci-run-unit fix an aggregation bug in VL1L2Info::operator+=().

* Per issue #2022, added _vcnt.txt output files to check to relevant tests based on if vcnt output file is being generated via the config file. SL

Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

* #1815 Renamed time_as_offset to Is_offset

* #1815 Added vx_data2d_dim_by_value

* #1815 Added convert_value_to_offset and renamed _time_dim_offset to _cur_time_index

* #1815 Added convert_value_to_offset and renamed _time_dim_offset to _cur_time_index. Support value instead of offset for time and z level

* #1815 Support @ for the value insteaed of offset for slicing

* #1815 Support value insteaed of offset for slicing

* #1815 Deleted unused local variable

* #1815 Deleted unused local variable

* #1815 Added level by value with @

* #1815 Added plot_data_plane_NCCF_latlon_by_value

* #1815 Added level by value with @

* Feature #2180 develop kft (#2181)

* dtcenter/METplus-Internal#16 Moved from scripts/sonarqube to internal/scripts/sonarqube

* #1815 Updated level

* Feature 2022 stat_analysis (#2185)

Proceeding with the merge without an external review based on the details listed above.

* Feature #2147 HSS (#2169)

* #1815 call is_eq to comapre two double values

* Per #2147, this is a HOTFIX to the develop branch after PR #2169 added new CTC and CTS columns. Prevoiusly the CTC columns = NBRCTC columns and CTS = NBRCTS. But that is no longer the case. This updates write_nbrctc_cols() and write_nbrcts_cols() to actually write them rather than just calling the functions to write CTC and CTS cols, respectively.

* #2187 Added add_offset_att_name & scale_factor_att_name

* #2187 Apply add_offse or scale_factor if defined

* ##2187 Removed handling add_offset and scale factor. They are applied at the base API

* #2187 Changed a log message

* Per #2193, add release notes for met-11.0.0-beta1. (#2195)

Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>

* Hotfix to develop since I forgot to update the version number in conf.py.

* #1815 Added more attribute names

* #1815 Added get_index_for_dim

* #1815 Formatting

* #1815 Support a differnt dimension name from thw first data variable

* #1815 Use constants for attr names

* Hotfix to the develop branch to fix paths in Dockefiles after restructuing the MET repo.

* Another hotfix to develop to get the Docker build step working again.

The failure from the configure script is caused by the version of the "alocal" executable.
The contents of develop are based on seneca, which has:
  aclocal (GNU automake) 1.16.1
By comparison, my laptop does NOT require that bootstrap be run for:
  aclocal (GNU automake) 1.16.5
But the Docker image has an older version which triggers the error:
  aclocal (GNU automake) 1.13.4

Any machine with aclocal 1.16.x works fine. Likely any machine with a version that differs from 1.16.x does not. Running bootstrap fixes that... but also changes the contents of all the Makefile.in files making them appear as a large set of diffs in the repo. This is not an issue inside the docker image since we generally remove the source code after compiling anyway.

* Updating the png version of the older flowcharts.

* #1815 cleanup

* #1815 cleanup

* #1851 cleanup

* #1851 cleanup

* #1815 Added get_att_unixtime

* #1851 cleanup

* #1815 cleanup

* #1815 cleanup

* #1815 Support @ for pinterp

* #1815 Do not call to_string

* #1815 cleanup

* Per issue #2081, updated thecontents to match MRMS Version 12.2. Updated existing entries, removed old entries, added new entries. SL (#2199)

Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>

* #1815 Changed @time to time at plot_data_plane_NCCF_time

* Revert "Feature 1815 level value" (#2201)

* #1815 Use NcVarInfo members instead API calls

* #1815 Added find_var_by_dim_name

* #1815 Restored changes for this branch. The changes were reset after revert and merging with latest develop branch

* #METplus-Internal_19 cleanup

* #METplus-Internal_19 Added more functiofnds and corrected typo

* #METplus-Internal_19 Added main.h and main.cc

* #METplus-Internal_19 adjusted link order to set oom

* #METplus-Internal_19 Renamed main to met_main. Moved oom handler to base API

* #METplus-Internal commented out segv_handler which failed to compile at Docker

* Fix typo - maintianing

* Feature #2204 sum (#2205)

* #2202 Added APIs to check the point data (missing data and data types)

* #2202 Renamed pointdata_from_xarray to pointdata_from_python_list

* #2202 Support python list

* #2202 Avoid seg fault by checking point data from python embedding and provides the better log messages

* #2202 Support python list

* #2202 Added APIs to check the point data (missing data and data types)

* #2202 Added APIs to check the point data (missing data and data types)

* #2202 Added APIs to check the point data (missing data and data types)

* #2202 Added MaskedArray to allowed array data type

* Per #2211, enhance warning/error messages when parsing threshold types in dictionary.cc.

* #2208 Check existence of ensemble member data before checking bad_data

* 2215 Added station_ob to message_type & station_id to station_id for metadata_map

* 2215 Add log message for missing message_type and station_id metadata variables. Set NA if a message type is empty string

* 2215 Filter out XXX@RecMetaData variables from @metadata variables

* Per #2215, update the user's guide to make it consistent with the default ioda2nc config file.

* #METplus-Internal_19 Renamed main to met_main and added get_tool_name

* Feature sonarqube v11 beta2 (#2222)

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>

* Per #2220, update the version number and release notes.

* Per #2220, fix typo.

* Per #2220, format the METplus-Internal release notes for MET in the same way they were handled for the METplus beta1 release.

* Added *hpp

* Separated template functions

* Separated template functions

* Changed argument for get_var_fill_value

* Feature 1971 mtd error to warning (#2221)

Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

* #2225 @Level string is not applied as an index and index string without @ is not applied as value

* Feature #2220 v11.0.0-beta2_try2 (#2228)

* Updating Hera and Jet files for 11.0.0 release

* Adding 11.0.0 modulefiles for Hera and Jet

* Updating cheyenne installation files

* Reformatted slashes in paths for hera config files

* Updating installation files for Orion

* Removed beta2 references

* Adding configuration and modulefiles for gaea installation

* Changing METdatadb references to METdataio

* Documentation-only commit directly to develop to correct a typo. The default dotsize if 1.0 rather than 10.

* Feature 2055 nbm grib2 update (#2234)

* Per issue #2055, in read_grib2_record_list() added new PDS numbers 6, 10, 15 (for NBM data). SL

* Per issue #2055: in read_grib2_record_list(), in section that validates PDS number changed, for undefined PDS numbers, changed Error to Warning and continue (instead of exit). SL

* Per issue #2055, created new entries for NBM grib2 data fields. SL

* Per issue #2055. Added more NBM fields based on a 12z, f003 file. SL

* Per issue #2055, after interogating several NBM lead-time files, added TMAX field. SL

* Per issue #2055, added grib2_nbm.txt to the list. SL

* Per #2055, update the grib2_nbm.txt file entries in the table_files Makefiles.

* Per issue #2055, fixed syntax entry for TSTM field. SL

* Per issue #2055, fixed a few more syntax errors for some of the fields. SL

* Per issue #2055, in read_grib2_record_list(), added section to set level values for template number 6 (NBM data). Also added some temporary print statements. SL

* Per issue  #2055, in read_grib2_record_list(), added code to set levels for table number 10 (like 6). SL

* Per #2055, adding support for new GRIB2_perc_val configuration option to filter records based on the forecast percentile value used by GRIB2 product definition templates 6 and 10. Seth, note that I also included the probability filtering logic tweak we discussed, since it was already present in that same file.

* Per issue #2055: in find_record_matches(), in section that resolves Prob fields, changed 'break' to 'continue' for non Probs. SL

* Per issue #2055, in read_grib2_record_list() cleaned up some commented out code. SL

* Per issue #2055, in read_grib2_record_list() cleaned up all print statements. SL

* Per issue #2055, added 5 new unit tests for NBM data. SL

* Update data2d_grib2.cc

* Update data2d_grib2.cc

Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

* Feature 2207 map (#2241)

* Feature #2237 tmp_dir (#2242)

* Per #2196, updating files for changes to met base image (#2246)

* Hotfix to the develop branch to fix typos in the names of 3 tools (grid_stat, gribtab_dat_to_flat, and gsidens2orank). Also removed commented out code from main.cc.

* Feature 2250 accum (#2251)

* Feature 2198 zenodo (#2252)

* Per #2198, adding Seth Linden and Dave Albo to the Author List

* Per #2198, updated Dave Albo to David Albo

* Per #2198, added three new authors based on submitted AMS abstract

* Per #2198, adding .zenodo.json file

* Per #2198, adding orcids for all based on Tatiana's suggestion

* Update .zenodo.json

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update .zenodo.json

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update .zenodo.json

Co-authored-by: johnhg <johnhg@ucar.edu>

Co-authored-by: johnhg <johnhg@ucar.edu>

* Per #1744, adding names for rst files in index.rst

* Reword to Grid-Stat opening paragraph

* Feature 2196 update dockerfile (#2249)

* Per #2196, update for upgrade to Python 3.8.6

* Updated based on new structure of METbaseimage

* Changed MET_BASE_IMAGE references to MET_BASE_TAG; Added information to the README.md file

* Changed MET_BASE_IMAGE references to MET_BASE_TAG; Updated the version from v1.0 to v1.1

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <johnhg@ucar.edu>

* Per #2196, updating README.md based on suggestions from John HG

Co-authored-by: johnhg <johnhg@ucar.edu>

* Feature 1774 contrib outline (#2253)

* creating chapter files

* putting a space in to work through the git add and commit process.

* Changed formatting of one header

Co-authored-by: Lisa Goodrich <lisag@seneca.rap.ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>

* Fine tune to grid-stat opening paragraph

* Feature 2206 fair crps to ecnt (#2247)

* Per issue #2206, for the ECNT line type, added CRPS_EMP_FAIR. SL

* Per issue #2206, for ECNT line type, added CRPS_EMP_FAIR. SL

* Per issue #2206, for ecnt_columns, added CRPS_EMP_FAIR. SL

* Per issue #2206, in write_ecnt_cols(), added crps_emp_fair. SL

* Per issue #2206, in ECNTInfo, added crps_emp_fair. SL

* Per issue #2206, started stubbing code pieced to calculate crps_emp_fair. SL

* Per issue #2206, added new function mean_abs_diff(). SL

* Per issue #2206, in compute_pair_vals() updated the code to calculate crps_emp and crps_emp_fair. SL

* Per issue #2206, added crps_emp_fair (CRPS_EMP_FAIR) to relevant code pieces. SL

* Per issue #2206, added wording for CRPS_EMP_FAIR, also added it to last column of ECNT line type. SL

* Per issue #2206, added info for CRPS_EMP_FAIR and also added the math equation for this. SL

* Per issue #2206, update the math equation for CRPS_EMP_FAIR. SL

* Per issue #2206, added new function weighted_mean_absolute_diff(). SL

* Per issue #2206, updated the crps_emp_fair calculation to subtract the weighted_mean_abs_diff. SL

* Per issue #2206, in aggr_orank_lines(), updated calculation for crps_emp_fair to use weighted_mean_abs_diff. SL

* Per issue #2206, renamed weighted_mean_abs_diff() to wmean_abs_diff(). SL

* Per issue #2206, for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL

* Per issue #2206, in aggr_orank_lines(), for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL

* Per issue #2206, updated the math equation for the CRPS_EMP_FAIR calculation. SL

* Per issue #2206, fixed a bug in the wmean_abs_diff() function. SL

* Per issue #2206, added code for crps_emp_fair. SL

* Per issue #2206, in set() function, added checks for crps_emp and crps_emp_fair, for values of 0.0. SL

Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>

* automated tests: added ability to trigger build of develop-lite docker image that it used in the METplus automated tests

* to fix issues with python embedding when the path changes, update development.docker file (apparently unused or rarely previously) to include changes for Python 3.8 including setting the LDFLAG to include -rpath to prevent needing LD_LIBRARY_PATH set to run the tools. Source the env file in the build MET docker script instead of setting the env vars in the configure command

* Hotfix to the develop branch to revert the python version from 3.8 back to 3.6. This is done by rolling back the base image in the MET Dockerfiles to dtcenter/met-base:v1.0. Using 3.8 caused the downstream METplus python embedding examples to fail via GHA in the METplus repo. Will write up an issue to investigate more during the MET-11.0.0-beta4 development cycle.

* Tweak the build_docker_image.sh script by removing references to MET_BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them.

* Revert "Tweak the build_docker_image.sh script by removing references to MET_BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them."

This reverts commit 5efc65e.

* Hotfix, found 2 more spots where I needed to change v1.1 to v1.0. We should really revisit having this setting spread across so many locations.

* Bugfix 2238 link error (#2255)

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>

* Feature dtcenter/METplus-Internal#15 add checksum to release (#2254)

Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

* feature 2216 ioda2nc station_id (#2259)

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

* Feature 1942 seeps (#2257)

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>

* Feature 2142 ascii2nc airnow (#2256)

Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

* Feature 1954 semilatlon (#2262)

Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>

* Removed future imports since they were used to transition from python 2 to 3. Rearranged logic to be more readible by checking error conditions and exiting if they are not met instead of putting all of the logic to run inside the if statement

* Feature 1908 remove ens (#2265)

* Feature 2266 v11.0.0-beta3 (#2268)

* Minor hotfix for the develop branch. Running bootstrap for develop on seneca changes the order of vx_grid semilatlon slightly. We probably manually editted that file instead of running bootstrap to regenerate it.

* Bugfix #2271 develop nbrctc (#2272)

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>

* Feature 2282 docs (#2283)

* #2270 Removed version number for SonrQube scanner pathdiff

* Feature #2286 grib_lookup (#2288)

* Feature 2227 namespace (#2290)

* Per #2227 changes in this commit resolve all errors from removing 'using namespace std' from all header files in the src/basic directory

* Attempt to resolve errors in GitHub actions from removing 'using namepsace std' from all src/basic/ libraries, plus removal from src/libcode/vx_gnomon/gnomon.h and src/libcode/vx_nc_util/nc_utils.h

* Attempt to fix GHA errors with compilation after removal of 'using namespace std'; locally compiles fine

* Per #2227, attempting to fix GHA compilation; Compiltion on seneca works fine

* Per #2227, attempt to resolve GHA compilation issues; seneca compilation works fine

* Per #2227, attempt to resolve GHA compilation issues; seneca compilation works fine

* Per #2227, removing namespace from vx_series_data library

* Per #2227, removing namespace std from vx_shapedata library

* Per #2227, removing namespace std from vx_data2d_grib2 and vx_data2d_grib libraries

* Per #2227, removing namespace std from vx_statistics library

* Per #2227, removing namespace std from src/tools/tc_utils

* Per #2227, removed namespace std from /src/tools/core header files

* Per #2227, clean up and continued work

* Per #2227, changes to remove namespace std and netCDF from header files

* Per #2227, resolve errors in GitHub Actions build

* Per #2227, resolve new errors in GitHub Actions build

* Per #2227, resolve new errors in GitHub Actions build

* Per #2227, resolve new errors in GitHub Actions build

* Per #2227, realign variables

* Per #2227, updating comment

* Per #2227, updating comment

* Per #2227, realign variables

* Per #2227, realign variables

* Per #2227, realign variables

* Per #2227, updating comment

* Update src/basic/vx_config/config.tab.cc

Co-authored-by: johnhg <johnhg@ucar.edu>

Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: johnhg <johnhg@ucar.edu>

* Feature #2237 test_empty_config (#2291)

* Feature #2297 gha (#2299)

* GHA hotfix to develop

Changes for #2297 included a small typo that I'm fixing directly in the develop branch.

* Feature #2297 hotfix to develop

A final hotfix to the develop branch to get the build_docker_trigger_metplus.yml workflow working again. I tested on feature_2297_gha branch to confirm that no double-quotes are actually needed.

* Update GHA versions

* Feature 2281 linker (#2296)

Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>

* Feature 2036 enhance tc pairs (#2301)

Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

* Feature 2276 enhance ascii2nc to read ndbc buoy data (#2294)

Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>

* Feature 2155 time units months and years (#2300)

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>

* removing release-notes out of overview and creating a seperate chapter for this information. (#2304)

* Bugfix #2309 develop tcmpr (#2310)

* Bugfix #2306 ascii2nc airnow hourly (#2314)

Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu>

* Feature #2058 bias_ratio (#2317)

* Feature 2232 refine grid diag (#2316)

Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>

* Feature #392 tcdiag_line_type (#2315)

* Feature #2068 ioda2nc v2.0 (#2307)

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>

* Feature #2322 v11.0.0-beta4 (#2323)

* Feature #2325 ECNT_MAE (#2326)

* Hotfix to the develop branch to correct the column numbers in the CNT line type table for the RMSOA, ANOM_CORR_UNCNTR, and SI statistics.

* Feature #2332 spread_md (#2333)

* Per #2232, add SPREAD_MD to the ECNT line type from Ensemble-Stat and computed for HiRA.

* Per #2332, fix compilation error.

* Per #2332, update date and release notes for met-11.0.0-beta4.

* Per #2332, fix compilation error.

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: Randy Bullock <bullock@seneca.rap.ucar.edu>
Co-authored-by: davidfillmore <fillmore.winslow.david@gmail.com>
Co-authored-by: rgbullock <bullock@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu>
Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: Seth Linden <linden@ucar.edu>
Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: Seth Linden <linden@kiowa.rap.ucar.edu>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@seneca.rap.ucar.edu>
Co-authored-by: mo-mglover <78152252+mo-mglover@users.noreply.github.com>
Co-authored-by: davidalbo <dave@ucar.edu>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: Molly Smith <molly.b.smith@noaa.gov>
Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu>
Co-authored-by: Jonathan Vigh <jvigh@ucar.edu>
Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com>
Co-authored-by: Lisa Goodrich <lisag@seneca.rap.ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Tropical Cyclone Tools priority: high High Priority requestor: DTC/PAS DTC Physics Across Scales T&E requestor: NOAA/HFIP NOAA Hurricane Forecast Improvement Project
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants