Update main_v9.1-ref after 1572 (v9.1.1 release) #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entoried. This helps debugging issues with MET potentially not reading all input GRIB2 records on WCOSS.
* Per #1562, check for bad data values before adding data to the PDF's for grid_diag. * Per #1562, removing the poly = CONUS.poly mask from GridDiagConfig_TMP. That settting masked a problem in the handling of missing data. Exercising the mask.poly option is tested in another unit test. This will change the output and break the nightly build, but that's good since we'll do more thorough testing.
…to print out some additional log messages that may help in debugging the intermittent file list failure.
* Per #1572, delete the docs/version file as it is not needed here. * Per #1572, update the version number to 9.1.1. * Per #1572, list the met-9.1.1 release date as 20201119 for the docs. * Per #1572, add release notes for the met-9.1.1 verison. * Per #1572, add release notes for met-9.1.1 version. * Per #1572, let's try to release met-9.1.1 today 11/18.
20 tasks
|
As expected, the NB for main_v9.1 failed again for NB20201120. I checked again this morning that all of the diffs are confined to the MTD output files for which no diffing logic currently exists, and they are. Those diffs will go away once we update the reference version. |
jprestop
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting to update the contents of main_v9.1-ref with the latest version of main_v9.1. The NB failed, as expected, after doing the v9.1.1 release. The test scripts do not know how to handle version differences in the output from MTD.
Pull Request Testing
I inspected the diffs flagged in:
kiowa:/d1/projects/MET/MET_regression/main_v9.1/NB20201119/test_regression_20201119.log
All the differences occur in the MTD output files. It's also a good idea to update since computing diffs for different version numbers is much slower than computing diffs when the version numbers match.
Recommend testing for the reviewer to perform, including the location of input datasets:
None.
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Updating the reference version.
After merging, should the reviewer DELETE the feature branch from GitHub? [No]
Do not delete the main_v9.1 branch.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone