Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1319 no pickle #1666

Closed
wants to merge 36 commits into from
Closed

Feature 1319 no pickle #1666

wants to merge 36 commits into from

Conversation

dwfncar
Copy link
Contributor

@dwfncar dwfncar commented Feb 17, 2021

This a partial PR for replacing pickle files with NetCDF files in the write_pickle_dataplane.py and read_pickle_dataplane.py wrappers.
These are now write_tmp_dataplane.py and read_tmp_dataplane.py.
write_pickle_point.py and write_pickle_mpr.py and still under revision,
as well as the Python3_Script class.

@dwfncar dwfncar self-assigned this Feb 17, 2021
@dwfncar dwfncar added this to the MET 10.0.0 milestone Feb 17, 2021
@georgemccabe
Copy link
Collaborator

@davidfillmore it looks like the destination of this PR is the main branch. It should be the develop branch.

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

David, you requested that this PR be merged into main_v9.1 instead of develop. Please either change the target branch to develop (if possible) or close this PR and submit a new one. Also, please fill out the Pull Request template info to give the reviewer information about what testing has already been done, what should be done, and whether or not it should change the output of the NB.

@JohnHalleyGotway JohnHalleyGotway removed the request for review from georgemccabe February 17, 2021 17:59
@dwfncar dwfncar changed the base branch from main_v9.1 to develop February 18, 2021 19:20
@dwfncar
Copy link
Contributor Author

dwfncar commented Mar 5, 2021

This pull request will be re-issued with only the dataplane NetCDF replacement for pickle.

@dwfncar dwfncar closed this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For python embedding, replace temporary pickle files with temporary NetCDF or ASCII files.
3 participants