Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1694 grid_diag #1696

Merged
merged 4 commits into from
Mar 5, 2021
Merged

Bugfix 1694 grid_diag #1696

merged 4 commits into from
Mar 5, 2021

Commits on Mar 4, 2021

  1. Per #1694, add VarInfo::magic_str_attr() to construct a field summary…

    … string from the name_attr() and level_attr() functions.
    JohnHalleyGotway committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    9c9c54c View commit details
    Browse the repository at this point in the history
  2. Per #1694, fixing 2 issues here. There was a bug in the computation o…

    …f the max value. Had a less-than sign that should have been greater-than. Also, switch from tracking data by it's magic_str() to simply using VAR_i and VAR_j strings. We *could* have just used the i, j integers directly, but constructing the ij joint histogram integer could have been tricky since we start numbering with 0 instead of 1. i=0, j=1 would result in 01 which is the same as integer of 1. If we do want to switch to integers, we just need to make them 1-based and add +1 all over the place.
    JohnHalleyGotway committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    a16bebc View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Configuration menu
    Copy the full SHA
    21e3eb7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f84a5a View commit details
    Browse the repository at this point in the history