Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1782 point_stat_NCCF #1783

Merged
merged 1 commit into from
May 7, 2021
Merged

Bugfix 1782 point_stat_NCCF #1783

merged 1 commit into from
May 7, 2021

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented May 7, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

How to test

The same test at the issue

point_stat  prods_op_gl-mn_20210302_00_012.nc lndsyn_2021030212.nc PointStatConfig

at kiowa

/d1/personal/hsoh/git/bugfix/bugfix_1782_point_stat_NCCF/MET/met/bin/point_stat  /d1/personal/hsoh/data/MET-1782/prods_op_gl-mn_20210302_00_012.nc /d1/personal/hsoh/data/MET-1782/lndsyn_2021030212.nc /d1/personal/hsoh/data/MET-1782/PointStatConfig

@hsoh-u hsoh-u added this to the MET 10.0.0 milestone May 7, 2021
@hsoh-u hsoh-u linked an issue May 7, 2021 that may be closed by this pull request
21 tasks
@JohnHalleyGotway JohnHalleyGotway changed the title #1782 point_stat_NCCF - NCCF input without the time dimension bugfix 1782 point_stat_NCCF May 7, 2021
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsoh-u thanks for working on this so quickly! I built your bugfix branch locally and confirmed that that Point-Stat test does now run and produce MPR output. I did also run unit_point_stat.xml and confirmed that all of the existing tests continue to run without error.

I did NOT run a full regression test to make sure we don't have any unexpected diffs. But due to our shot timeline I recommend merging this change in and letting tonight's nightly build perform that test for us.

I approve of these changes.

@hsoh-u hsoh-u merged commit 6c9b78e into develop May 7, 2021
@JohnHalleyGotway JohnHalleyGotway deleted the bugfix_1782_point_stat_NCCF branch May 10, 2021 23:35
@JohnHalleyGotway JohnHalleyGotway changed the title bugfix 1782 point_stat_NCCF Bugfix 1782 point_stat_NCCF May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Point-Stat runtime error when verifying CF-compliant NetCDF files.
2 participants